Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update more versions #2351

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Auto-update more versions #2351

merged 8 commits into from
Feb 17, 2023

Conversation

trask
Copy link
Member

@trask trask commented Feb 16, 2023

Let me know if you'd like to change anything. After you merge this, it should pick up this lagging javaVersion that we haven't been updating as a good test that it's working (I've also tested it in my fork).

@trask trask requested a review from a team February 16, 2023 05:34
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I'm so looking forward to reviewing this more closely, but it might not be until later today or tomorrow. If another maintainer approves before then, I'm ok if this lands sooner than later.

I do have some comments about making the script runnable locally, in particular under macOS. I'd made improvements to .github/workflows/scripts/check-collector-version.sh so that it could be run locally and in a "dry-run" mode. I'd like to preserve that ability. I don't mind submitting followup changes.

@chalin
Copy link
Contributor

chalin commented Feb 16, 2023

Just sharing a few ideas of the top. Will share more later.

@svrnm
Copy link
Member

svrnm commented Feb 16, 2023

I like that!

@chalin I am wondering if we should move those versions into a data/ file and then use from there at the different places, wdyt? (Does not have to be part of this PR)

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. See inline comments and questions, thanks.

.github/workflows/auto-update-versions.yml Outdated Show resolved Hide resolved
.github/workflows/auto-update-versions.yml Outdated Show resolved Hide resolved
.github/workflows/scripts/auto-update-version.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/auto-update-version.sh Outdated Show resolved Hide resolved
trask and others added 4 commits February 16, 2023 13:43
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@trask
Copy link
Member Author

trask commented Feb 16, 2023

I do have some comments about making the script runnable locally, in particular under macOS. I'd made improvements to .github/workflows/scripts/check-collector-version.sh so that it could be run locally and in a "dry-run" mode. I'd like to preserve that ability. I don't mind submitting followup changes.

ya, sorry about that, I generally just test jobs in my fork, but I totally support adding those features back

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an inline comment about adding a guard. Otherwise, this LGTM. Thanks!

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on account of the question about the guard being addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants