Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style inline images as blocks with a border #2359

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 17, 2023

  • Closes Treat images as figures by default, and add a border etc #2358 using styles only. Maybe we can consider use of a render hook later.
  • Ensures that image elements in markdown are treated as block-level elements
  • Adds a light border around images, which is necessary (in most cases) when the image background is white. The border around barker images isn't a problem in general.
  • Supports an easy way to declare that an image:
    • Shouldn't have a border by adding {.border-0} after an image. There's an example of this in the PR.
    • Isn't a figure, by using the img-initial class.
  • Closes Add a frame border to an image #2271

Preview:

Screenshots

Before:

image

After:

image

@chalin chalin requested review from a team and djaglowski and removed request for a team February 17, 2023 14:05
@chalin chalin force-pushed the chalin-im-img-defaults-2023-02-17 branch from b0e3d19 to c46fdd2 Compare February 17, 2023 14:16
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy notification batman. I approve!

@chalin
Copy link
Contributor Author

chalin commented Feb 17, 2023

LOL, thanks for the review and approval @cartermp! ✨

@chalin chalin merged commit 252bd67 into open-telemetry:main Feb 17, 2023
@chalin chalin deleted the chalin-im-img-defaults-2023-02-17 branch February 17, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat images as figures by default, and add a border etc
2 participants