-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New get started guide for the Collector #3426
New get started guide for the Collector #3426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Some more remarks
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, 2 minor things left. Let's wait for 0.88 then
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Looks like you will have to wait for open-telemetry/opentelemetry-collector-contrib/pull/28565, sorry 😞 will let you know as soon as we have released this |
No worries! Hopefully we don't have to wait for 0.89 (in that case we might consider going with running telemetrygen in a docker container as well??) |
I want to do a 0.88.1 release just for telemetrygen since I consider this to be a serious enough issue. Will keep you updated in any case. |
telemetrygen should work now :) |
@theletterf can you take a look at the remaining open conversations? I think after that we should be good to merge :-) |
@svrnm I believe there are no more pending items |
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
there are 3 open conversations unfortunately they are hidden behind that "3 hidden conversations. Load more" |
Saw them afterwards and solved them (I think)! |
Ah, yes, now they are resolved, let me check again |
Done, thank you @theletterf |
This solves #1695 and potentially a few others.
I went for the simplest possible approach:
At the same time I've split the install instructions into a separate page.