Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New get started guide for the Collector #3426

Merged
merged 23 commits into from
Oct 25, 2023

Conversation

theletterf
Copy link
Member

This solves #1695 and potentially a few others.

I went for the simplest possible approach:

  • Download the binary or Docker image
  • Run with default configuration
  • Install telemetrygen
  • Send traces
  • Check in zpages

At the same time I've split the install instructions into a separate page.

@theletterf theletterf requested review from a team and codeboten and removed request for a team October 23, 2023 12:30
@theletterf
Copy link
Member Author

@svrnm As commented by @mx-psi, the instructions for telemetrygen will only work once 0.88 has been released.

@svrnm
Copy link
Member

svrnm commented Oct 23, 2023

@svrnm As commented by @mx-psi, the instructions for telemetrygen will only work once 0.88 has been released.

Shouldn't take long until we have that release, right?

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Some more remarks

content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/collector/getting-started.md Show resolved Hide resolved
content/en/docs/collector/getting-started.md Show resolved Hide resolved
content/en/docs/collector/getting-started.md Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member

mx-psi commented Oct 24, 2023

@svrnm As commented by @mx-psi, the instructions for telemetrygen will only work once 0.88 has been released.

Shouldn't take long until we have that release, right?

Should be done either today or tomorrow

theletterf and others added 10 commits October 24, 2023 10:45
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@theletterf
Copy link
Member Author

@svrnm All changes applied. Re: Collector capitalization, are you aware of #3411?

@svrnm
Copy link
Member

svrnm commented Oct 24, 2023

@svrnm All changes applied.

Thanks!

Re: Collector capitalization, are you aware of #3411?

I somehow missed that discussion

@theletterf theletterf requested a review from svrnm October 24, 2023 09:42
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, 2 minor things left. Let's wait for 0.88 then

theletterf and others added 2 commits October 24, 2023 12:03
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@mx-psi
Copy link
Member

mx-psi commented Oct 24, 2023

Looks like you will have to wait for open-telemetry/opentelemetry-collector-contrib/pull/28565, sorry 😞 will let you know as soon as we have released this

@svrnm
Copy link
Member

svrnm commented Oct 24, 2023

Looks like you will have to wait for open-telemetry/opentelemetry-collector-contrib/pull/28565, sorry 😞 will let you know as soon as we have released this

No worries! Hopefully we don't have to wait for 0.89 (in that case we might consider going with running telemetrygen in a docker container as well??)

@mx-psi
Copy link
Member

mx-psi commented Oct 24, 2023

Looks like you will have to wait for open-telemetry/opentelemetry-collector-contrib/pull/28565, sorry 😞 will let you know as soon as we have released this

No worries! Hopefully we don't have to wait for 0.89 (in that case we might consider going with running telemetrygen in a docker container as well??)

I want to do a 0.88.1 release just for telemetrygen since I consider this to be a serious enough issue. Will keep you updated in any case.

@mx-psi
Copy link
Member

mx-psi commented Oct 25, 2023

telemetrygen should work now :)

@svrnm
Copy link
Member

svrnm commented Oct 25, 2023

@theletterf can you take a look at the remaining open conversations? I think after that we should be good to merge :-)

@theletterf
Copy link
Member Author

@svrnm I believe there are no more pending items

theletterf and others added 5 commits October 25, 2023 15:22
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@theletterf theletterf requested a review from svrnm October 25, 2023 14:47
@svrnm
Copy link
Member

svrnm commented Oct 25, 2023

@svrnm I believe there are no more pending items

there are 3 open conversations unfortunately they are hidden behind that "3 hidden conversations. Load more"

@theletterf
Copy link
Member Author

Saw them afterwards and solved them (I think)!

@svrnm
Copy link
Member

svrnm commented Oct 25, 2023

Ah, yes, now they are resolved, let me check again

@svrnm svrnm merged commit e32ba3b into open-telemetry:main Oct 25, 2023
14 checks passed
@svrnm
Copy link
Member

svrnm commented Oct 25, 2023

Done, thank you @theletterf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants