Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for peer service mapping #3428

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 23, 2023

After providing the possibility to override peer.service attribute by host, port and path in opentelemetry-java-instrumentation. This add documentation.

@mmorel-35 mmorel-35 requested review from a team October 23, 2023 22:34
@mmorel-35 mmorel-35 changed the title Complete documentation for peer service mapping Add documentation for peer service mapping Oct 23, 2023
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for following up on the doc!

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor remarks.

After providing the possibility to override peer.service attribute by host, port and path. This add documentation.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@svrnm svrnm merged commit 0e938bd into open-telemetry:main Oct 25, 2023
@mmorel-35 mmorel-35 deleted the patch-1 branch October 25, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants