Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA] Rename /docs/instrumentation to /docs/languages, and Manual subpages to Instrumentation #3761

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jan 11, 2024

I was once again trying to wrap my head around #3228, and I wanted to start with a first part of what I have proposed in this comment:

  • Replace top level section "Instrumentation" with "Language APIs & SDKs". This (imho) makes it also easier for people to find what they are looking for if they are not yet firm in the wording (aka they don't know what "Instrumentation" means)
  • Replace "Manual" with "Instrumentation" because this guide is going in detail on how to instrument your code (here I assume that someone went through the getting started and is already aware of what "Instrumentation" is)

This PR purposefully is not yet touching the word "Automatic", this is worth a separate consideration

Final Note, I kick this off as a draft PR for discussion, because right now this PR only changes linkTitles and if we want to go with this change, we need to rename files & URLs and have to manage a ton of aliases.

@open-telemetry/docs-approvers PTAL

Preview: https://deploy-preview-3761--opentelemetry.netlify.app/docs/languages/

Redirect tests (selected):

Screenshot 2024-01-12 at 16 22 57

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, as it leaves the door open to further variants, such as "automatic instrumentation". I do wonder, though: Isn't this sort of assuming that the code based instrumentation is the default way of instrumenting? That might not be true for runtime languages like Node or Java.

I like @pellared 's structure here, which might inform a deeper restructuring of our docs: #3228 (comment)

@svrnm
Copy link
Member Author

svrnm commented Jan 11, 2024

Sounds reasonable, as it leaves the door open to further variants, such as "automatic instrumentation". I do wonder, though: Isn't this sort of assuming that the code based instrumentation is the default way of instrumenting? That might not be true for runtime languages like Node or Java.

I'll make a strong statement now and say, yes, code based instrumentation is the default way, because telemetry should be built-in, so agents and instrumentation libraries are only an intermediate thing until otel is native everywhere. We see this actually happening for Java with the Spring Boot Starter and for Node.Js with nextjs having otel built-in natively (and by that not needing any instrumentation library anymore)

I like @pellared 's structure here, which might inform a deeper restructuring of our docs: #3228 (comment)

I was thinking about this as well, because "Instrumentation" right now also includes "Bootstrap/Setup the SDK" right now, which probably should be extracted (maybe in it's own PR). We have something for "How you "instrument libraries" which is called "Libraries" in some of the languages.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! 👍🏻

netlify.toml Outdated
Comment on lines 18 to 21
[[redirects]]
from = "/docs/instrumentation/*"
to = "/docs/languages/:splat"
force = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack, add this rule to the new languages index file instead. Follow the Registry page as an example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following to the Languages index front matter:

aliases: [/docs/instrumentation]
redirects: [{ from: /docs/instrumentation/*, to: ':splat' }]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cartermp
Copy link
Contributor

I like the concept of the change. I'm happy to proceed with this moving out of a draft for review.

@svrnm svrnm marked this pull request as ready for review January 15, 2024 08:32
@svrnm svrnm requested review from a team and jpkrohling and removed request for a team January 15, 2024 08:32
@svrnm svrnm added enhancement New feature or request docs labels Jan 15, 2024
@pellared
Copy link
Member

I think it is a great improvement.

@cartermp
Copy link
Contributor

The main thing in my mind here is:

This PR purposefully is not yet touching the word "Automatic", this is worth a separate consideration

It looks a little odd without some tweaks to both the automatic sections and the (if relevant) libraries sections. That's a separate issue to tackle, but it needs tackling.

@svrnm
Copy link
Member Author

svrnm commented Jan 15, 2024

The main thing in my mind here is:

This PR purposefully is not yet touching the word "Automatic", this is worth a separate consideration

It looks a little odd without some tweaks to both the automatic sections and the (if relevant) libraries sections. That's a separate issue to tackle, but it needs tackling.

Agreed, we need to review the other section titles as well! Let's have some follow up PRs then

Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
@chalin chalin force-pushed the remove-manual-instrumentation branch from f83ddd9 to 2f38f7a Compare January 15, 2024 16:07
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, the redirects for manual pages aren't implemented correctly. Let me see how we can fix this.

@chalin
Copy link
Contributor

chalin commented Jan 15, 2024

@svrnm - actually, if you'd like to merge this now, I can fix the redirects in a followup PR. WDYT?

Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm
Copy link
Member Author

svrnm commented Jan 15, 2024

@svrnm - actually, if you'd like to merge this now, I can fix the redirects in a followup PR. WDYT?

as discussed via slack I try to fix them right now because there are a few other things that need to be updated (links on the status page)

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In particular the redirects are fixed.

See inline for minor suggestions.

content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/java/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/net/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/php/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/python/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/swift/instrumentation.md Outdated Show resolved Hide resolved
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@chalin chalin changed the title Remove 'manual instrumentation' from navigation [IA] Rename /docs/instrumentation to /docs/languages, and Manual subpages to Instrumentation Jan 15, 2024
@svrnm svrnm changed the title [IA] Rename /docs/instrumentation to /docs/languages, and Manual subpages to Instrumentation [IA] Rename /docs/instrumentation to /docs/languages, and Manual subpages to Instrumentation Jan 15, 2024
@svrnm svrnm merged commit 06837fe into open-telemetry:main Jan 15, 2024
14 checks passed
@chalin chalin mentioned this pull request Jan 15, 2024
33 tasks
@chalin chalin added the IA Information architecture rework label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request IA Information architecture rework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants