Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade all NPM pksg, gulp to v5, add check-markdown wrapper as workaround #4233

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Apr 2, 2024

Here's the workaround in action, from https://github.com/open-telemetry/opentelemetry.io/actions/runs/9428586176/job/25974087551?pr=4233:

Run npm run check:markdown

> check:markdown
> scripts/check-markdown-wrapper.sh

WARNING: required symlink target does not exist, creating it: content-modules/opentelemetry-go/example
+ mkdir -p content-modules/opentelemetry-go/example
+ exec npm run _check:markdown

> _check:markdown
> npx gulp lint-md

[12:08:19] Using gulpfile ~/work/opentelemetry.io/opentelemetry.io/gulpfile.js
[12:08:20] Starting 'lint-md'...
Processed [4](https://github.com/open-telemetry/opentelemetry.io/actions/runs/9428586176/job/25974087551?pr=4233#step:6:5)48 files, 0 had issues.
[12:08:23] Finished 'lint-md' after 3.[6](https://github.com/open-telemetry/opentelemetry.io/actions/runs/9428586176/job/25974087551?pr=4233#step:6:7)9 s

@chalin chalin added the CI/infra CI & infrastructure label Apr 2, 2024
@chalin chalin requested a review from a team April 2, 2024 11:15
@chalin chalin added the blocked label Apr 2, 2024
@chalin
Copy link
Contributor Author

chalin commented Apr 2, 2024

@chalin chalin marked this pull request as draft April 2, 2024 11:57
@chalin chalin force-pushed the chalin-im-gulp-v5-2024-04-02 branch from a689b92 to 98e41b7 Compare April 2, 2024 15:18
@chalin chalin marked this pull request as ready for review April 2, 2024 15:19
@chalin chalin removed the blocked label Apr 2, 2024
@cartermp
Copy link
Contributor

cartermp commented Apr 3, 2024

/fix:all

Copy link
Contributor

github-actions bot commented Apr 3, 2024

@chalin chalin marked this pull request as draft April 3, 2024 08:18
@chalin
Copy link
Contributor Author

chalin commented Apr 3, 2024

Works locally, and on GitPod, but not under GH actions :-/ ... will need to investigate further when I have the time. Putting in draft in the meantime.

@chalin chalin force-pushed the chalin-im-gulp-v5-2024-04-02 branch from bee7b08 to 1b8e19d Compare April 22, 2024 16:20
@chalin chalin force-pushed the chalin-im-gulp-v5-2024-04-02 branch 4 times, most recently from e178e54 to 4ac0828 Compare June 8, 2024 10:27
@chalin chalin force-pushed the chalin-im-gulp-v5-2024-04-02 branch from 6343657 to db5f433 Compare June 8, 2024 12:00
@chalin chalin marked this pull request as ready for review June 8, 2024 12:07
@chalin chalin changed the title [CI] Upgrade gulp to v5 [CI] Upgrade all NPM pksg, gulp to v5, add check-markdown wrapper as workaround Jun 8, 2024
@chalin
Copy link
Contributor Author

chalin commented Jun 8, 2024

Finally all green! Merging ✨

@chalin chalin merged commit f87b4bd into open-telemetry:main Jun 8, 2024
16 checks passed
@chalin chalin deleted the chalin-im-gulp-v5-2024-04-02 branch June 8, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants