Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document logs and metrics for quote service #4279

Merged
merged 10 commits into from
Apr 13, 2024

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Apr 11, 2024

Closes: #2669

@brettmc brettmc requested review from a team April 11, 2024 00:46
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small grammar and style suggestions. Thanks!

content/en/docs/demo/services/quote.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/quote.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/quote.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/quote.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/quote.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/quote.md Outdated Show resolved Hide resolved
brettmc and others added 2 commits April 11, 2024 11:35
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of that @brettmc! 🤩

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Just a couple nits. Thank you!

content/en/docs/demo/services/quote.md Outdated Show resolved Hide resolved
content/en/docs/demo/services/quote.md Outdated Show resolved Hide resolved
@cartermp cartermp merged commit d7e40cf into open-telemetry:main Apr 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTel Demo] - Quote Service Metrics
6 participants