Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark mode] Banner compatibility prep #4347

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Apr 23, 2024

Screenshots

Before:

image
image

After:

image
image

On mobile:

image

@chalin chalin requested a review from a team April 23, 2024 19:03
@chalin chalin marked this pull request as draft April 23, 2024 19:09
@chalin chalin added the blocked label Apr 23, 2024
@chalin chalin force-pushed the chalin-im-banner-in-dark-mode-2024-04-23 branch from 92ee6e4 to 93fc783 Compare April 23, 2024 19:14
@chalin chalin mentioned this pull request Apr 23, 2024
9 tasks
@chalin chalin force-pushed the chalin-im-banner-in-dark-mode-2024-04-23 branch from 93fc783 to 935f622 Compare April 30, 2024 12:30
@chalin chalin force-pushed the chalin-im-banner-in-dark-mode-2024-04-23 branch from 935f622 to 9622be9 Compare April 30, 2024 12:32
@chalin chalin removed the blocked label Apr 30, 2024
@chalin chalin marked this pull request as ready for review April 30, 2024 12:34
@chalin chalin merged commit dfdf072 into open-telemetry:main Apr 30, 2024
15 checks passed
@chalin chalin deleted the chalin-im-banner-in-dark-mode-2024-04-23 branch April 30, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants