Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post on Go Contrib modules removal (code owners needed) #4543

Merged
merged 17 commits into from
May 28, 2024
Merged

Post on Go Contrib modules removal (code owners needed) #4543

merged 17 commits into from
May 28, 2024

Conversation

theletterf
Copy link
Member

Fixes #4502

@theletterf theletterf requested a review from a team May 27, 2024 08:12
@theletterf theletterf self-assigned this May 27, 2024
@github-actions github-actions bot added the blog label May 27, 2024
@theletterf theletterf mentioned this pull request May 27, 2024
Closed
@theletterf theletterf requested a review from a team May 27, 2024 08:20
pellared
pellared approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment 👍

content/en/blog/2024/go-contrib-removal.md Outdated Show resolved Hide resolved
chalin
chalin reviewed May 28, 2024
View reviewed changes
content/en/blog/2024/go-contrib-removal.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-contrib-removal.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-contrib-removal.md Outdated Show resolved Hide resolved
@theletterf
Copy link
Member Author

@pellared @dmathieu @chalin PTAL, I've addressed all comments (I think). I'd rather keep the clickbaity title, though — it's hard to find volunteers these days, and "removal" is quite true in the end.

chalin
chalin reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the title: it drives the most important point home.

On the other hand, @pellared seemed to indicate that the modules are considered deprecated -- see #4543 (comment). Can we add a comment to that effect?

@theletterf
Copy link
Member Author

@chalin Addressed your comments in 08a1098 and 93967b3 — thanks!

@theletterf theletterf requested a review from chalin May 28, 2024 11:45
@cartermp cartermp merged commit c748b01 into main May 28, 2024
17 checks passed
@cartermp cartermp deleted the theletterf-blog-post-go-contrib-removal branch May 28, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@MrAlias MrAlias MrAlias approved these changes

@pellared pellared pellared approved these changes

@dmathieu dmathieu dmathieu approved these changes

@chalin chalin Awaiting requested review from chalin

Assignees

@theletterf theletterf

Labels
blog sig:go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[blog] Notice about removal of Go Contrib modules and call for Code Owners
6 participants
@theletterf @dmathieu @chalin @pellared @MrAlias @cartermp