-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Localize index page #4580
[ja] Localize index page #4580
Conversation
Thanks @ymotongpoo, can you ask someone who is also a native Japanese speaker to provide a review? @chalin does this PR everything you need to add Japanese as a language to the website? |
@shirou @katzchang can either of you review the JA translation? The volume is pretty small. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
As I mentioned during the Comms meeting yesterday, I'll get to this as soon as I can. There's an i18n feature I may want to put into place first.
That being said, there are rebase conflicts. Please rebase and force push and I'll take a look after. I tried rebasing myself, but I'm not qualified to resolve the merge conflicts because I don't understand Japanese 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I still can't rebase, I have made all the necessary fixes. For a preview, see https://deploy-preview-4580--opentelemetry.netlify.app/ja/
IMHO, this is good to merge.
hugo.yaml
Outdated
# params: | ||
# description: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a Japanese translation of "The OpenTelemetry Project Site" to put in these lines. No rush, it can be handled in a followup PR.
@chalin Thank you for your review and I rebased and force pushed my branch to resolve conflicts. I also added metadata in Hugo config for Japanese pages. |
Docs PR Checklist
opentelemetry.io repository.
Preview: https://deploy-preview-4580--opentelemetry.netlify.app/ja/