Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] CVE-2024-36129 post followup #4605

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 5, 2024

/cc @jpkrohling @mx-psi @arminru

@chalin chalin requested a review from a team June 5, 2024 21:10
linkTitle: Security vulnerability in confighttp and configgrpc
Security vulnerability in OTel Collector confighttp and configgrpc
(CVE-2024-36129)
linkTitle: Collector vulnerability CVE-2024-36129
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other alternative short titles (which show up in the left nav), one of which is just the CVE ID.
Also, I wasn't sure if you felt that "Security" had to be part of the short title or not. Anyhow, let me know what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings about whether to put 'Security' in there or not, I am fine with removing if that makes things easier

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the title says configgrpc and confighttp, the link title can omit them.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge as is from my side

linkTitle: Security vulnerability in confighttp and configgrpc
Security vulnerability in OTel Collector confighttp and configgrpc
(CVE-2024-36129)
linkTitle: Collector vulnerability CVE-2024-36129
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings about whether to put 'Security' in there or not, I am fine with removing if that makes things easier

@chalin chalin force-pushed the chalin-im-CVE-2024-36129-2024-06-05 branch from 3e53065 to 08525fe Compare June 6, 2024 14:28
@svrnm svrnm merged commit 6bae678 into open-telemetry:main Jun 7, 2024
15 checks passed
@chalin chalin deleted the chalin-im-CVE-2024-36129-2024-06-05 branch June 7, 2024 10:26
ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jun 8, 2024
Co-authored-by: Severin Neumann <neumanns@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants