Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Adjust-pages script cleanup and semconv vers tweak #4944

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 3, 2024

  • Drops patches in adjust-pages.pl, now that spec PRs have landed in the Git submodules of this repo
  • Semconv: when linking to model YAML files, links to the specific semconv version of the file rather than blob/main

/cc @open-telemetry/specs-semconv-approvers


$ git diff | grep ^diff
diff --git a/docs/specs/semconv/azure/events/index.html b/docs/specs/semconv/azure/events/index.html
diff --git a/site/index.html b/site/index.html

Other than the site/index.html timestamp change, here's the only other change to the generated site files:

$ git diff
diff --git a/docs/specs/semconv/azure/events/index.html b/docs/specs/semconv/azure/events/index.html
index 185e4e29ed..10eb31bda4 100644
--- a/docs/specs/semconv/azure/events/index.html
+++ b/docs/specs/semconv/azure/events/index.html
@@ -2728,7 +2728,7 @@ Resource Log events.</p>
 </tbody>
 </table>
 <!-- end of manually added table -->
-<p>See <a href="https://github.com/open-telemetry/semantic-conventions/blob/main//model/logs/azure.yaml" target="_blank" rel="noopener" class="external-link">Azure Resource Log definition</a> for the details.</p>
+<p>See <a href="https://github.com/open-telemetry/semantic-conventions/tree/v1.27.0//model/logs/azure.yaml" target="_blank" rel="noopener" class="external-link">Azure Resource Log definition</a> for the details.</p>
 
        <style>
   .feedback--answer {

@chalin chalin added the CI/infra CI & infrastructure label Aug 3, 2024
@chalin chalin requested a review from a team August 3, 2024 00:07
@chalin chalin force-pushed the chalin-im-adjust-pages-script-2024-08-02 branch from 5a17b45 to cac6823 Compare August 3, 2024 10:00
@chalin chalin merged commit d63caf5 into open-telemetry:main Aug 3, 2024
17 checks passed
@chalin chalin deleted the chalin-im-adjust-pages-script-2024-08-02 branch August 3, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants