-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor java SDK and configuration #4966
Merged
theletterf
merged 22 commits into
open-telemetry:main
from
jack-berg:refactor-java-configuration
Sep 17, 2024
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7c9b308
wip
jack-berg 8e66d72
Rework sdk and config organization
jack-berg 35cf9e4
Delete exporter, sampling, resources pages
jack-berg c37779e
Formatting
jack-berg 22fbd57
revert unrelated
jack-berg bbc633c
PR feedback
jack-berg 2b4ed4c
Remove usages of that
jack-berg bb99974
PR feedback
jack-berg a53743d
Rebase, upgrades Docsy
chalin b3ce1f3
Use section-relative paths
chalin e9e96ac
Fix htmltest regex
chalin 0093e32
Fix warnings: use path for OTel spec reference not URL
chalin e8099d3
Fix spelling
chalin e2cf0e8
Fix format
chalin c782083
Fix capitalization
chalin 9f70156
Fix link into spec, the hash doesn't exist
chalin e5151f3
Copyedit
chalin 3f70a41
Fix typo
jack-berg 6e75629
update opentelemetry-java-examples to latest
jack-berg e2e128e
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
jack-berg 45b6b8a
merge main, fix build error
svrnm 9cab82c
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
jack-berg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,7 @@ jaeger | |
jaegertracing | ||
javaagent | ||
javadoc | ||
javadocs | ||
jboss | ||
jdbc | ||
julia | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ cascade: | |
vers: | ||
instrumentation: 2.8.0 | ||
otel: 1.42.1 | ||
contrib: 1.38.0 | ||
semconv: 1.27.0 | ||
weight: 18 | ||
--- | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svrnm @theletterf - what do you think about this rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it catch "Java documentation" as well? So, if I write "to learn more about this, read the "Java documentation". Otherwise I am fine, since
Javadoc
seems to be the official notationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be an issue for sentences like "You will find more details on that in the Java documentation" meaning our internal java documentation. So we need to make sure that it does only capture "java doc(s)" with a word boundary (
\b
if I am not wrong?)