Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributor guide URL #4978

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

Metal-Bat
Copy link
Contributor

@Metal-Bat Metal-Bat commented Aug 6, 2024

fixes #4971

@Metal-Bat Metal-Bat requested a review from a team August 6, 2024 21:05
Copy link

linux-foundation-easycla bot commented Aug 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@opentelemetrybot opentelemetrybot requested review from a team August 6, 2024 21:06
@chalin chalin changed the title fix(contributor-guide-url): fixed #4971: corrected contributor guide url Fix contributor guide URL Aug 6, 2024
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Metal-Bat.

LGTM, but ... I have a question for @open-telemetry/docs-maintainers: generally, an en page fix must not be propagated to non-en languages, since the locale maintainers need to update the default_lang_commit too. We might want to make an exception when a 404 is being fixed? WDYT?

I'm leaning towards this PR be exclusively for en pages. Other locales can handle their own page updates. But I'm willing to be convinced otherwise. I don't have a strong opinion about this.

/cc @emdneto

@Metal-Bat
Copy link
Contributor Author

I think you are making a good point
so if teams accept this idea i would be glad to add persian documents to this project

Thank you everyone

@theletterf
Copy link
Member

I'm leaning towards this PR be exclusively for en pages.

+1. Exceptions might become unmanageable in the long run.

@svrnm
Copy link
Member

svrnm commented Aug 7, 2024

I'm leaning towards this PR be exclusively for en pages.

+1. Exceptions might become unmanageable in the long run.

Agred.

so if teams accept this idea i would be glad to add persian documents to this project

Thanks for the offer @Metal-Bat! Can you raise a dedicated issue for that? Note, that we need at least 2 people, 3 would be even better to work on that, since we as non-persian speakers can not help you with reviewing the content. Also note, that localizations are still a new thing to the OpenTelemetry website, so onboarding of new languages is still a slow process

@chalin
Copy link
Contributor

chalin commented Aug 7, 2024

@Metal-Bat - please drop the non-en page changes from this PR.

@Metal-Bat
Copy link
Contributor Author

I'm leaning towards this PR be exclusively for en pages.

+1. Exceptions might become unmanageable in the long run.

Agred.

so if teams accept this idea i would be glad to add persian documents to this project

Thanks for the offer @Metal-Bat! Can you raise a dedicated issue for that? Note, that we need at least 2 people, 3 would be even better to work on that, since we as non-persian speakers can not help you with reviewing the content. Also note, that localizations are still a new thing to the OpenTelemetry website, so onboarding of new languages is still a slow process

sure i will open an issue and i will find some people to start this documentation

@Metal-Bat Metal-Bat closed this Aug 7, 2024
@Metal-Bat Metal-Bat reopened this Aug 7, 2024
@opentelemetrybot opentelemetrybot requested review from a team August 7, 2024 11:00
@Metal-Bat
Copy link
Contributor Author

I'm leaning towards this PR be exclusively for en pages.

sure

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin chalin added this pull request to the merge queue Aug 7, 2024
Merged via the queue into open-telemetry:main with commit 3078352 Aug 7, 2024
17 checks passed
@chalin
Copy link
Contributor

chalin commented Aug 7, 2024

Thanks all!

sure i will open an issue and i will find some people to start this documentation

@Metal-Bat et al. - heads up that Docsy (and hence this repo) doesn't fully support RTL languages yet. I'm working on it, but the feature might not land for a few weeks or months -- though I do see it happening before the end of the year. Reference: google/docsy#1442.

@Metal-Bat
Copy link
Contributor Author

Thanks all!

sure i will open an issue and i will find some people to start this documentation

@Metal-Bat et al. - heads up that Docsy (and hence this repo) doesn't fully support RTL languages yet. I'm working on it, but the feature might not land for a few weeks or months -- though I do see it happening before the end of the year. Reference: google/docsy#1442.

great thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[docs/contributing] OpenTelemetry Contributor Guide link is broken
5 participants