Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Install cspell/dict before running cspell action #5008

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 9, 2024

@chalin chalin added the CI/infra CI & infrastructure label Aug 9, 2024
@chalin chalin requested a review from a team August 9, 2024 12:31
@chalin
Copy link
Contributor Author

chalin commented Aug 9, 2024

Woohoo, spell checking is working now for non-en languages, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/10319248972/job/28567258019?pr=5008:

Run streetsidesoftware/cspell-action@v6
cspell-action
Pull Request
Warning: Unknown word (Telemetría) Suggestions: (telemetria, telemetric, telemetrias, telemétrica, telemetry)
content/es/_index.md:4:3 Unknown word (Telemetría) Suggestions: (telemetria, telemetric, telemetrias, telemétrica, telemetry)
content/es/_index.md:4:59 Unknown word (observabilidad) Suggestions: (observabilidade, observabilidades, observability, obsedabilidade, obsediabilidade)
content/es/_index.md:48:54 Unknown word (telemetría) Suggestions: (telemetria, telemetric, telemetrias, telemétrica, telemetry)
content/es/_index.md:62:28 Unknown word (telemetría) Suggestions: (telemetria, telemetric, telemetrias, telemétrica, telemetry)
content/es/_index.md:63:1 Unknown word (reenvíalos) Suggestions: (reenvia-os, reenviados, reenviamos, reenviarlos, reenviá-los)
content/es/_index.md:80:60 Unknown word (observabilidad) Suggestions: (observabilidade, observabilidades, observability, obsedabilidade, obsediabilidade)

/cc @theletterf

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@chalin chalin merged commit df8711a into open-telemetry:main Aug 9, 2024
16 of 17 checks passed
@chalin chalin deleted the chalin-im-spell-check-es-fix-2024-08-09 branch August 9, 2024 12:44
@chalin
Copy link
Contributor Author

chalin commented Aug 9, 2024

Merging now so that we can test the functionality over #5009.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants