-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry tip to ocb #5028
base: main
Are you sure you want to change the base?
Add registry tip to ocb #5028
Conversation
Signed-off-by: svrnm <neumanns@cisco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of wording suggestions
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
@open-telemetry/collector-approvers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyedits
To find components that you can add to your custom Collector, take a look | ||
the | ||
[OpenTelemetry Registry](https://opentelemetry.io/ecosystem/registry/?language=collector). | ||
In addition to available components, the Registry provides the full string you need to | ||
add to your `builder-config.yaml`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To find components that you can add to your custom Collector, take a look | |
the | |
[OpenTelemetry Registry](https://opentelemetry.io/ecosystem/registry/?language=collector). | |
In addition to available components, the Registry provides the full string you need to | |
add to your `builder-config.yaml`. | |
For a list of components that you can add to your custom collector, see the [OpenTelemetry Registry](/ecosystem/registry/?language=collector). Note that registry entries provide the full string you need to add to your `builder-config.yaml`. |
By the way, what is "the full string" -- i.e., it is a full string of what? The component name or ID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, IMHO, "collector" should be in lowercase (as I suggest in the previous comment) in "custom collector" because we're not talking about the OTel Collector. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "full string" is something like this:
exporters:
- gomod:
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/influxdbexporter v0.108.0
I see how this is not clear, the "full component name and version you need" might be better?
It's still an OpenTelemetry Collector, it's just a custom one, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how this is not clear, the "full component name and version you need" might be better?
Yes. I see that you've made this change already. Thanks.
It's still an OpenTelemetry Collector, it's just a custom one, I guess?
Well, the fact that you write "an OpenTelemetry Collector" means that even you don't think that it is the Collector. IMHO, the Collector should refer to a fixed (for any given version) binary. Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, there is no fixed binary of the collector afaik, even for the ones we deliver as community there is "Core" and "Contrib" and some other distributions. My understanding so far was, that we say Collector when we mean an OpenTelemetry collector build from https://github.com/open-telemetry/opentelemetry-collector, this includes the "Whatever Distribution of OpenTelemetry Collector", and custom Collectors, but if someone has a component that collects telemetry or whatever it's a collector.
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10726540918 |
IMPORTANT: (RE-)RUN
|
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
A small addition to the collector builder documentation, that the registry can be used to find configuration for components.