-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[outreachy] updated registry with inline help tooltips #5450
base: main
Are you sure you want to change the base?
Conversation
Hello, @svrnm I have made another PR with the changes and the correct files to work on as per our last discussion. |
@@ -34,10 +34,54 @@ | |||
{{ end -}} | |||
{{ $types = $types | uniq | sort -}} | |||
|
|||
<!--Custom css for the inline help--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move custom CSS into this file:
https://github.com/open-telemetry/opentelemetry.io/blob/main/assets/scss/_registry.scss
Doing so, make sure that the CSS is only applied on that page, e.g. right now if we use "btn-outline-success" class on any other page the hover::after would also be applied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks mentor I will update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that you provide the update today, such that I still can review it. I will not be available for more feedback afterwards until the end of the application phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, otherwise lgtm
This PR resolves #5420. I implemented hover hints on key action buttons to make clear to users what they can expect when they click these buttons. The buttons show users exactly how to interact with different parts of the OpenTelemetry registry.
I also added a hover hint on the alert text that describes what OpenTelemetry Registry is, further describing what the Telemetry is, without leaving the page itself.
Example of the hover hint in one of the action buttons.
Hover hint in the alert description