Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] translate demo/_index and demo/architecture page into ja #5863

Merged
merged 7 commits into from
Jan 4, 2025
Merged

[ja] translate demo/_index and demo/architecture page into ja #5863

merged 7 commits into from
Jan 4, 2025
+278 −0

Conversation

yugo-ibuki
Copy link
Contributor

I translated demo page (_index and architecture).

@yugo-ibuki yugo-ibuki requested a review from a team as a code owner January 2, 2025 06:55
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 2, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@opentelemetrybot opentelemetrybot requested review from a team January 2, 2025 06:55
ymotongpoo
ymotongpoo requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I added comments to your translation. Most of the requests are nit format changes, not the quality of the translation.

content/ja/docs/demo/_index.md Outdated
@@ -0,0 +1,81 @@
---
title: OpenTelemetryのデモ ドキュメンテーション
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「OpenTelemetryのデモ」→「OpenTelemetryデモ」

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: 1e11ab2

content/ja/docs/demo/_index.md Outdated
default_lang_commit: 1e69c8f94a605ce5624c6b6657080d98f633ac7b
---

[OpenTelemetryのデモ](/ecosystem/demo/)のドキュメンテーションへようこそ。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: 1e11ab2

content/ja/docs/demo/_index.md Outdated

## サービスドキュメント

各サービスのOpenTelemetryのデプロイの仕方に関する具体的な情報は、こちらで確認できます：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文末コロンは日本語にはないので、文末は読点に変更してください。

Copy link
Contributor Author

@yugo-ibuki yugo-ibuki Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: 6bf9b51

content/ja/docs/demo/_index.md Outdated

OpenTelemetryを使用してどのように問題を解決できるでしょうか？
これらのシナリオでは、事前に設定された問題を紹介し、
それらを解決するためにOpenTelemetryのデータをどのように解釈するかを説明します。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一文の途中で改行しないようにお願いします。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for mixing the fixes with other commits.

ref: a24ec50#diff-b2afef1990c0a704cbbde1a935a1b01782bfd16b90d1eaed74eccd1938f2b6c9R59

content/ja/docs/demo/_index.md Outdated
[OpenTelemetryのデモ](/ecosystem/demo/)のドキュメンテーションへようこそ。
ここでは、デモのインストール方法や実行方法、そしてOpenTelemetryの動作を確認できるいくつかのシナリオについて説明しています。

## デモの実行
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見出しは英語版と同じURLでアンカーが生成されるように手動で追加してください。

ref: https://github.com/open-telemetry/opentelemetry.io/blob/main/content/ja/docs/concepts/components.md?plain=1#L25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: a24ec50

content/ja/docs/demo/_index.md Outdated
- メモリリークを発見し、メトリクスとトレースを使用して診断。
[詳細](scenarios/recommendation-cache/)

## リファレンス
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

アンカーの追加

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: a24ec50

content/ja/docs/demo/architecture.md Show resolved Hide resolved
content/ja/docs/demo/architecture.md Outdated
classDef typescript fill:#e98516,color:black;
```

デモアプリケーションの
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改行を消す

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: 742887b

content/ja/docs/demo/architecture.md Outdated
[トレース](/docs/demo/telemetry-features/trace-coverage/)の計装の現状については、
リンクをご確認ください。

コレクターの設定は
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: 742887b

content/ja/docs/demo/architecture.md Outdated
リンクをご確認ください。

コレクターの設定は
[otelcol-config.yml](https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/otelcollector/otelcol-config.yml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: 742887b

@opentelemetrybot opentelemetrybot requested a review from a team January 2, 2025 08:15
@yugo-ibuki yugo-ibuki requested a review from ymotongpoo January 2, 2025 08:39
ymotongpoo
ymotongpoo requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Except for one nit change, all LGTM.

@opentelemetrybot opentelemetrybot requested a review from a team January 4, 2025 04:09
@yugo-ibuki
Copy link
Contributor Author

Thank you for reviewing!

one nit change

I fixed this request at ec1c4f3 .

@yugo-ibuki yugo-ibuki requested a review from ymotongpoo January 4, 2025 04:13
ymotongpoo
ymotongpoo approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymotongpoo ymotongpoo force-pushed the ja/demo/architecture branch from ec1c4f3 to bba6084 Compare January 4, 2025 08:48
@opentelemetrybot opentelemetrybot requested a review from a team January 4, 2025 08:48
@chalin chalin added this pull request to the merge queue Jan 4, 2025
Merged via the queue into open-telemetry:main with commit d37f619 Jan 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@ymotongpoo ymotongpoo ymotongpoo approved these changes

Assignees
No one assigned
Labels
lang:ja
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yugo-ibuki @ymotongpoo @chalin