Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fixes to github.com links for opentelemetry-dotnet-instrumentation and more #5973

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 17, 2025

@chalin chalin requested a review from a team as a code owner January 17, 2025 22:06
@chalin chalin changed the title Chalin im rw GitHub link fixes 2025 01 17 1640 et [CI] Fixes github.com links for opentelemetry-dotnet-instrumentation and more Jan 17, 2025
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

repo: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/struts-2.3
repo: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/struts/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask - does this look ok to you? (AFAIR you added this entry.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this looks good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming.

[available here](https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation-genai/opentelemetry-instrumentation-openai-v2/example).
[available here](https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link fix, cc @lmolkova @drewby

@chalin
Copy link
Contributor Author

chalin commented Jan 17, 2025

Going to merge now (before the OTel spec and Semconv updates). I'll address any comments in a followup PR.

@chalin chalin merged commit 6d7a4a7 into open-telemetry:main Jan 17, 2025
18 checks passed
@chalin chalin deleted the chalin-im-rw-github-link-fixes-2025-01-17-1640ET branch January 17, 2025 22:16
@chalin chalin changed the title [CI] Fixes github.com links for opentelemetry-dotnet-instrumentation and more [CI] Fixes to github.com links for opentelemetry-dotnet-instrumentation and more Jan 17, 2025
- [CentOS 7 x64](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docker/centos-build.dockerfile)
- [CentOS 7 x64](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/v1.9.0/docker/centos-build.dockerfile)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/dotnet-approvers - can you comment on this update. Maybe rather than pinning down to v1.9.0, you would have preferred that I use https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docker/centos-stream9.dockerfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants