Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the arrow_service.proto file by removing 'f5' reference from the Go package name #20

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Aug 22, 2023

Both the arrow_service.proto and the proto/generate.sh files are referencing f5. I replaced it with open-telemetry. I don't think this modification will impact the experimental OTel Collector as the script was already dealing with it.

@lquerel lquerel requested a review from jmacd as a code owner August 22, 2023 22:54
@lquerel lquerel requested a review from moh-osman3 August 22, 2023 22:55
@lquerel lquerel merged commit bc7c254 into open-telemetry:main Aug 23, 2023
@jmacd jmacd mentioned this pull request Aug 25, 2023
jmacd added a commit that referenced this pull request Aug 25, 2023
Includes #13, #20, #21, #22, #23.
Releasing often - this makes it easier to integrate for `go.mod` users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants