Support raising consumer memory limit; return error when something's wrong #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d/err_mem_limit_option
…d/err_mem_limit_option
Merged
jmacd
added a commit
that referenced
this pull request
Aug 31, 2023
Release v0.3.0 includes: - #24 - #29 - #30 - #36 This release includes a BREAKING CHANGE 🛑 🛑 🛑 🛑 🛑. We do not anticipate another of these, it merely renames/enumbers status codes to match the gRPC status code numbering scheme. However, since status code 0 stays the same, it will result in unusual looking errors but should be safe to deploy the receivers first. Their CANCELED (i.e., SERVER_SHUTDOWN) will read as UNAVAILABLE, etc. See #27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a memory-limit error, returned when the Arrow library does not have enough memory.
Fixes #28.
Adds a
RESOURCE_EXHAUSTEDstatus code. Restructures the way gRPC Status errors are handled, i.e., produced in the arrow receiver and turned intoconsumererror.Permanenterrors on the exporter side.While doing this, I noticed that each of our status codes has an analog in the gRPC status code numbering space, and I have switched this repo to use identical naming and numbering.
Renames
SERVER_SHUTDOWNtoCANCELED.This is a breaking change, requires exporters and receivers to restart. This will allow us to be transparent with future OTel developments that rely on gRPC codes. For now, we have OK, Unavailable, InvalidArgument, ResourceExhausted, and Canceled (formerly known as SERVER_SHUTDOWN).