Adds the OTel Collector's MetricsLevel configuration, use it to control consumer metrics #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the concept of detailed-level metrics. When detailed metrics are in use, a per-stream-unique attribute will be added.
When normal metrics are in use, three new counters are available.
When basic metrics are in use (or are disabled), no new metrics are used.
This adds a new assertion in Consumer.Close() which warns about memory leaks that were not released, enabled with the Arrow-standard
--tags=assertbuild flag.This adds a correction to overcome "drift" in the memory inuse accounting, which was happening. (Uncomment a Println in this PR to see it.) Now, when a leak is discovered in Close() the metrics are manually closed out by subtracting inuse.