Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(batchprocessor): enable parallel exports in the batch processor #90

Merged
merged 6 commits into from
Nov 8, 2023
Merged

(batchprocessor): enable parallel exports in the batch processor #90

merged 6 commits into from
Nov 8, 2023

Conversation

moh-osman3
Copy link
Contributor

@moh-osman3 moh-osman3 commented Nov 8, 2023 •
edited
Loading

Part 3 of #80

This PR:

  • renames component to concurrentbatchprocessor
  • when items are sent, export is called in a goroutine

jmacd
jmacd reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

collector/processor/batchprocessor/batch_processor.go Outdated Show resolved Hide resolved
@moh-osman3 moh-osman3 marked this pull request as ready for review November 8, 2023 20:37
jmacd
jmacd approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@jmacd jmacd merged commit affade9 into open-telemetry:main Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@lquerel lquerel Awaiting requested review from lquerel lquerel is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moh-osman3 @jmacd