[otep] Propose adding env variables as context carriers to specification #258

adrielp · 2024-05-25T23:06:19Z

Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a Draft and hasn't had movement since last November.

There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage.

On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise.

Thanks for all the hard work to the original author (@deejgregor) and opening the draft #241

CC. TC sponsors @jsuereth @carlosalberto

deejgregor · 2024-05-25T23:10:10Z

@adrielp thank you for picking up this work. I appreciate that while I’ve been going through a busy time (and not sure when it will wrap up).

text/0258-env-context-baggage-carriers.md

pellared

👍

Co-authored-by: Robert Pająk <pellared@hotmail.com>

pellared

Awesome OTEP 👍

lmolkova

Added some minor comments.

Approving under the assumption that traceparent and tracestate format is intended to be identical to the W3C Trace-Context spec (and that we document it explicitly)

text/0258-env-context-baggage-carriers.md

carlosalberto · 2024-10-08T14:55:41Z

Overall LGTM, albeit I'd like to have a pair of things called out:

On propagating other formats: we are taking for granted we will only want to propagate traceparent (tracecontext), whereas there is a small chance that for legacy reasons b3 or similar is supported in a given environment, hence:
Suggest/standardize even the usage of TRACEPARENT, but allow the user to override the environment variable name (useful for overriding purposes + allowing the easy usage of any legacy format).
- I believe this is mentioned as part of the "Changed" section, but a clearer note would help IMHO.

svrnm

overall lgtm, some comments, especially around the use of HTTP vs network in general.

text/0258-env-context-baggage-carriers.md

svrnm

LGTM!

text/0258-env-context-baggage-carriers.md

adrielp · 2024-10-15T14:49:10Z

Overall LGTM, albeit I'd like to have a pair of things called out:

On propagating other formats: we are taking for granted we will only want to propagate traceparent (tracecontext), whereas there is a small chance that for legacy reasons b3 or similar is supported in a given environment, hence:

Suggest/standardize even the usage of TRACEPARENT, but allow the user to override the environment variable name (useful for overriding purposes + allowing the easy usage of any legacy format).

I believe this is mentioned as part of the "Changed" section, but a clearer note would help IMHO.

I've adjust the changed section slightly. Let me know if that tracks with what you were hoping for.

adrielp · 2024-10-15T16:27:01Z

Added some minor comments.

Approving under the assumption that traceparent and tracestate format is intended to be identical to the W3C Trace-Context spec (and that we document it explicitly)

@lmolkova - after the SIG, I pushed another update which hopefully makes this more clear within the document. Please feel free to give it another review and let me know if the changes do indeed add that clarity.

text/0258-env-context-baggage-carriers.md

@deejgregor

…ion (open-telemetry#258) Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a [Draft](https://github.com/open-telemetry/oteps/pull/241/files) and hasn't had movement since last November. There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage. On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise. Thanks for all the hard work to the original author (@deejgregor) and opening the draft open-telemetry#241 CC. TC sponsors @jsuereth @carlosalberto --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

@deejgregor

…ion (open-telemetry#258) Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a [Draft](https://github.com/open-telemetry/oteps/pull/241/files) and hasn't had movement since last November. There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage. On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise. Thanks for all the hard work to the original author (@deejgregor) and opening the draft open-telemetry#241 CC. TC sponsors @jsuereth @carlosalberto --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

@deejgregor

…ion (open-telemetry/oteps#258) Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a [Draft](https://github.com/open-telemetry/oteps/pull/241/files) and hasn't had movement since last November. There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage. On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise. Thanks for all the hard work to the original author (@deejgregor) and opening the draft open-telemetry#241 CC. TC sponsors @jsuereth @carlosalberto --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

@deejgregor

…ion (open-telemetry#258) Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a [Draft](https://github.com/open-telemetry/oteps/pull/241/files) and hasn't had movement since last November. There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage. On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise. Thanks for all the hard work to the original author (@deejgregor) and opening the draft open-telemetry#241 CC. TC sponsors @jsuereth @carlosalberto --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

@deejgregor

…ion (open-telemetry#258) Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a [Draft](https://github.com/open-telemetry/oteps/pull/241/files) and hasn't had movement since last November. There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage. On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise. Thanks for all the hard work to the original author (@deejgregor) and opening the draft open-telemetry#241 CC. TC sponsors @jsuereth @carlosalberto --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

@deejgregor

…ion (open-telemetry/oteps#258) Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a [Draft](https://github.com/open-telemetry/oteps/pull/241/files) and hasn't had movement since last November. There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage. On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise. Thanks for all the hard work to the original author (@deejgregor) and opening the draft #241 CC. TC sponsors @jsuereth @carlosalberto --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

[otep] add env-context-baggage-carriers otep

5a1b39e

adrielp requested a review from a team May 25, 2024 23:06

[chore] rename otep on pr and fix lint errors

34848d1

yurishkuro reviewed May 26, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

yurishkuro reviewed May 26, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

yurishkuro reviewed May 26, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

yurishkuro reviewed May 26, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

christophe-kamphaus-jemmic reviewed May 26, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

adrielp changed the title ~~[otep] add env-context-baggage-carriers otep~~ [otep] Propose adding env variables as context carriers to specification May 26, 2024

adrielp added 2 commits May 26, 2024 19:03

[chore] rewrite otep after original re-opening.

229ffa5

[chore] reformatting

ceee1bf

adrielp requested review from yurishkuro and christophe-kamphaus-jemmic May 26, 2024 23:16

yurishkuro reviewed May 27, 2024

View reviewed changes

danielgblanco mentioned this pull request Jun 3, 2024

Environment Variables as Carrier for Inter-Process Propagation to transport context open-telemetry/opentelemetry-specification#740

Open

[chore] small toc fix

84995f1

moserke mentioned this pull request Jul 10, 2024

Support TRACEPARENT for Opentelemetry hashicorp/terraform#35444

Open

adrielp mentioned this pull request Sep 5, 2024

Iterate on Env Context Propagation OTEP open-telemetry/semantic-conventions#1392

Closed

adrielp mentioned this pull request Sep 17, 2024

Introduce environment variables for propagating context to subprocesses #263

Closed

adrielp added 3 commits September 17, 2024 10:11

chore: minor updates

01c0925

[docs]: update based on feedback

e8be78f

[docs] linting fixes

85a0e20

adrielp mentioned this pull request Sep 24, 2024

Inter-process context propagation requirements #241

Closed

pellared reviewed Oct 1, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

pellared reviewed Oct 1, 2024

View reviewed changes

Update text/0258-env-context-baggage-carriers.md

f1860e4

Co-authored-by: Robert Pająk <pellared@hotmail.com>

pellared approved these changes Oct 1, 2024

View reviewed changes

lmolkova approved these changes Oct 1, 2024

View reviewed changes

magnusbaeck reviewed Oct 1, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

apparentlymart mentioned this pull request Oct 2, 2024

[RFC] Introduce OpenTelemetry to the OpenTofu codebase opentofu/opentofu#2028

Open

4 tasks

carlosalberto approved these changes Oct 8, 2024

View reviewed changes

svrnm reviewed Oct 9, 2024

View reviewed changes

adrielp and others added 2 commits October 14, 2024 12:52

chore: add updates based on feedback

51c8c6f

Merge branch 'main' into env-context-prop

bcee6cc

svrnm approved these changes Oct 14, 2024

View reviewed changes

trask reviewed Oct 14, 2024

View reviewed changes

adrielp added 2 commits October 15, 2024 10:44

chore: additional adjustments based on feedback

b6b5412

chore: emphasize the standardization on the useage of TRACEPARENT

ab02453

chore: change originates to is defined in

48477ca

austinlparker approved these changes Oct 15, 2024

View reviewed changes

chore: additional verbiage and clarity

d01849b

christophe-kamphaus-jemmic reviewed Oct 15, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

text/0258-env-context-baggage-carriers.md Outdated Show resolved Hide resolved

trask approved these changes Oct 15, 2024

View reviewed changes

chore: syntax cleanup

482530b

christophe-kamphaus-jemmic approved these changes Oct 16, 2024

View reviewed changes

tylerbenson reviewed Oct 21, 2024

View reviewed changes

text/0258-env-context-baggage-carriers.md Show resolved Hide resolved

Merge branch 'main' into env-context-prop

87cbc6f

lmolkova merged commit 3c044d4 into open-telemetry:main Oct 22, 2024
4 checks passed

adrielp deleted the env-context-prop branch October 22, 2024 17:18

christophe-kamphaus-jemmic mentioned this pull request Nov 8, 2024

REQUEST: New membership for christophe-kamphaus-jemmic open-telemetry/community#2433

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[otep] Propose adding env variables as context carriers to specification #258

[otep] Propose adding env variables as context carriers to specification #258

adrielp commented May 25, 2024 •

edited

Loading

deejgregor commented May 25, 2024 •

edited

Loading

pellared left a comment

pellared left a comment

lmolkova left a comment

carlosalberto commented Oct 8, 2024

svrnm left a comment

svrnm left a comment

adrielp commented Oct 15, 2024

adrielp commented Oct 15, 2024

[otep] Propose adding env variables as context carriers to specification #258

[otep] Propose adding env variables as context carriers to specification #258

Conversation

adrielp commented May 25, 2024 • edited Loading

deejgregor commented May 25, 2024 • edited Loading

pellared left a comment

Choose a reason for hiding this comment

pellared left a comment

Choose a reason for hiding this comment

lmolkova left a comment

Choose a reason for hiding this comment

carlosalberto commented Oct 8, 2024

svrnm left a comment

Choose a reason for hiding this comment

svrnm left a comment

Choose a reason for hiding this comment

adrielp commented Oct 15, 2024

adrielp commented Oct 15, 2024

adrielp commented May 25, 2024 •

edited

Loading

deejgregor commented May 25, 2024 •

edited

Loading