This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
Simplify the rfc process #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RFCs are now approved during the initial PR * README shortened for clarity * status line removed from RFC template * start date and PR link added to RFC template
tedsuo
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tigrannajaryan and
yurishkuro
as code owners
yurishkuro
reviewed
Sep 26, 2019
tigrannajaryan
approved these changes
Sep 26, 2019
songy23
approved these changes
Sep 26, 2019
c24t
approved these changes
Sep 26, 2019
reyang
reviewed
Sep 26, 2019
reyang
reviewed
Sep 26, 2019
| ### Integrating the RFC into the Spec | ||
| * Once an RFC is `approved`, an issue is created in the [specification repo](https://github.com/open-telemetry/opentelemetry-specification) to integrate the RFC into the spec. | ||
| * When reviewing the spec PR for the RFC, focus on whether the spec is written clearly, and reflects the changes approved in the RFC. Please abstain from relitigating the approved RFC changes at this stage. | ||
| * An RFC is `integrated` when four reviewers github-approve the spec PR. The PR is then merged, and the spec is versioned. |
There was a problem hiding this comment.
Do we enforce one single spec PR for each RFC, or we allow (or even encourage) multiple smaller PRs?
There was a problem hiding this comment.
Hmmmm, that's a good question. Hopefully RFCs are tightly scoped enough that it would not be an issue to make a single PR. If multiple PRs were needed, I think that would be fine... so long as we don't accidentally release a version of the spec with half an RFC!!
yurishkuro
approved these changes
Sep 26, 2019
bogdandrutu
approved these changes
Sep 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the proposal in #54
Resolves #32
Resolves #54