-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out incubating artifact #41
Merged
jack-berg
merged 10 commits into
open-telemetry:main
from
jack-berg:split-out-incubating-artifact
Feb 8, 2024
Merged
Split out incubating artifact #41
jack-berg
merged 10 commits into
open-telemetry:main
from
jack-berg:split-out-incubating-artifact
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I pushed a commit that allows the same thing to be accomplished without open-telemetry/build-tools#243. Its less convenient, but allows this PR to proceed independently of #40. Marking as ready to review. |
trask
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
jack-berg
force-pushed
the
split-out-incubating-artifact
branch
from
February 8, 2024 22:49
3a78097
to
279d886
Compare
…ventions-java into split-out-incubating-artifact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22. Embodies this proposal. Uses some of the concepts in #40, but without breaking out classes for each top level namespace.
Summary:
io.opentelemetry.semconv:opentelemetry-semconv-incubating
artifact for experimental semantic conventions.IncubatingResourceAttributes
andIncubatingSemanticAttributes
. (I think breaking out classes for top level namespaces in Semconv code generation prototype #40 is a good thing to do but can be done separately.)public static final String V1_23_1 = "https://opentelemetry.io/schemas/1.23.1"
. This is a running list of schema URL constants which needs to be manually updated.