Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out incubating artifact #41

Merged

Conversation

jack-berg
Copy link
Member

Resolves #22. Embodies this proposal. Uses some of the concepts in #40, but without breaking out classes for each top level namespace.

Summary:

  • Break out new io.opentelemetry.semconv:opentelemetry-semconv-incubating artifact for experimental semantic conventions.
  • Incubating artifact has files IncubatingResourceAttributes and IncubatingSemanticAttributes. (I think breaking out classes for top level namespaces in Semconv code generation prototype #40 is a good thing to do but can be done separately.)
  • Delete all hardcoded deprecated constants from jinja template. We've been keeping those around while we work out a strategy for Develop strategy for differentiating stable vs. experimental conventions, publishing stable artifact #22, and we now have a strategy. Additionally, its not obvious where we would put them. They don't belong in the artifact for stable conventions, and the names of the classes changes in the incubating artifact, so would break users anyway. Furthermore, I think we should break out classes for top level namespaces in a followup PR, which makes it harder to justify including the old deprecated constants.
  • Add new SchemaUrls class with constants of form public static final String V1_23_1 = "https://opentelemetry.io/schemas/1.23.1". This is a running list of schema URL constants which needs to be manually updated.

@jack-berg
Copy link
Member Author

I pushed a commit that allows the same thing to be accomplished without open-telemetry/build-tools#243.

Its less convenient, but allows this PR to proceed independently of #40. Marking as ready to review.

@jack-berg jack-berg marked this pull request as ready for review December 15, 2023 21:45
@jack-berg jack-berg requested a review from a team December 15, 2023 21:45
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@jack-berg jack-berg force-pushed the split-out-incubating-artifact branch from 3a78097 to 279d886 Compare February 8, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop strategy for differentiating stable vs. experimental conventions, publishing stable artifact
2 participants