New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup enum generation #52

Merged

jack-berg merged 1 commit into open-telemetry:main from jack-berg:cleanup-enums

Mar 14, 2024

Member

jack-berg commented Mar 14, 2024

Resolves #49.

Adds enum javadoc pointing back to corresponding attribute constant
Add deprecated javadoc / annotation based on same rules as attributes
Exclude the // Enum definitions comment if a namespace doesn't have any enums


          Cleanup enum generation

64e5ab4

jack-berg requested a review from a team

March 14, 2024 21:18

jack-berg commented

View reviewed changes

...v-incubating/src/main/java/io/opentelemetry/semconv/incubating/HttpIncubatingAttributes.java

+                 * @deprecated deprecated in favor of stable {@link
+                 *     io.opentelemetry.semconv.HttpAttributes.HttpRequestMethodValues} attribute.
+                 */
+                @Deprecated

Member Author

jack-berg Mar 14, 2024

This is a good example of the deprecated annotation. Javadoc links back to the stable equivalent.

trask approved these changes

View reviewed changes

jack-berg merged commit 379efda into open-telemetry:main

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet