Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSGi manifest headers for jars #87

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bdhoine
Copy link

@bdhoine bdhoine commented Aug 23, 2024

The gradle plugin that is added to the build is provided by BND tools: https://github.com/bndtools/bnd/tree/master/gradle-plugins. General info about BND tools can also be found on https://bndtools.org/

Adobe Experience Manager is also using the Maven variant for example in their archetype to achieve OSGi compatible JAR's bundles: https://github.com/adobe/aem-project-archetype/blob/master/src/main/archetype/pom.xml#L214

resolves #86

@jack-berg
Copy link
Member

There's a similar PR in opentelemetry-java right now: open-telemetry/opentelemetry-java#6669

My comment there is applicable here as well:

As someone without OSGi experience, I think its important to add some sort of end-to-end integration test. A sample app built with OSGi which consumes these artifacts and demonstrates it works as intended.

@bdhoine bdhoine marked this pull request as draft August 28, 2024 21:03
@bdhoine
Copy link
Author

bdhoine commented Aug 28, 2024

@jack-berg yes I noticed, @royteeuwen and myself are working on some details how to solve the current issues we are seeing while testing, this topic definitely needs some more work!

in the meanwhile I'm marking this one as draft

@bdhoine bdhoine force-pushed the 86-add-osgi-manifest-headers branch 3 times, most recently from e59f33f to a81e136 Compare August 28, 2024 23:27
@bdhoine bdhoine changed the title add OSGi manifest headers for jars Add OSGi manifest headers for jars Aug 28, 2024
@bdhoine bdhoine force-pushed the 86-add-osgi-manifest-headers branch 2 times, most recently from 89c7929 to 1a87892 Compare August 28, 2024 23:50
@bdhoine bdhoine force-pushed the 86-add-osgi-manifest-headers branch from 1a87892 to 1e4faa6 Compare August 28, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OSGi manifest headers
2 participants