cleuan up

.github/workflows/checks.yml

@@ -113,5 +113,5 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v1
-    - name: policies checks
+    - name: verify semantic conventions yaml definitions
       run: make check-policies

Makefile

@@ -234,4 +234,5 @@ check-policies:
 	docker run --rm -v $(PWD)/model:/source -v $(PWD)/docs:/spec -v $(PWD)/policies:/policies \
 		otel/weaver:${WEAVER_VERSION} registry check \
 		--registry=/source \
+		--policy=/policies/registry.rego \
 		--policy=/policies/attribute_name_collisions.rego

policies/attribute_name_collisions.rego

@@ -24,7 +24,7 @@ attr_registry_collision(description, attr_name) = violation {
     violation := {
         "id": description,
         "type": "semconv_attribute",
-        "category": "",
+        "category": "naming_collision",
         "attr": attr_name,
         "group": "",
     }
@@ -42,5 +42,5 @@ attr_names_except(excluded) = names {
     names := {n | n := input.groups[_].attributes[_].name} - excluded
 }
 
-excluded_const_collisions := {"m1essaging.client_id"}
-excluded_namespace_collisions := {"m1essaging.operation", "db.operation"}
+excluded_const_collisions := {"messaging.client_id"}
+excluded_namespace_collisions := {"messaging.operation", "db.operation", "deployment.environment"}

policies/registry.rego

@@ -8,7 +8,7 @@ package before_resolution
 attr_registry_violation(violation_id, group_id, attr_id) = violation {
 	violation := {
 		"id": violation_id,
-		"type": "semantic_convention_policies",
+		"type": "semconv_attribute",
 		"category": "attribute_registry_checks",
 		"group": group_id,
 		"attr": attr_id,