Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to map QUIC to network.* attributes #1237

Closed
antonfirsov opened this issue Jul 11, 2024 · 5 comments · Fixed by #1239
Closed

Figure out how to map QUIC to network.* attributes #1237

antonfirsov opened this issue Jul 11, 2024 · 5 comments · Fixed by #1239
Assignees

Comments

@antonfirsov
Copy link

antonfirsov commented Jul 11, 2024

Area(s)

network

Is your change request related to a problem? Please describe.

Edit: #1237 (comment)

Today it's not clear what network.* attributes should be assigned to what values when using QUIC or Unix Domain Sockets.

The attribute spec links to OSI definitions which do not list these protocols, and in fact these protocols do not map well to OSI concepts.
https://osi-model.com/network-layer/
https://osi-model.com/transport-layer/

#389 recommends mapping network.transport=quic for QUIC, which is not really accurate if we take OSI literally. I believe this is a source of confusion. The spec should provide explicit recommendations to help determine attribute choices for protocols that do not map well to OSI.

Describe the solution you'd like

After making a decision, make sure that quic and uds are listed as well-known values in the spec, making it clear what should be used.

Describe alternatives you've considered

No response

Additional context

No response

@antonfirsov antonfirsov changed the title Figure out how to map UDS and QUIC to network.* Figure out how to map UDS and QUIC to network.* attributes Jul 11, 2024
@antonfirsov
Copy link
Author

Sorry, missed that there is network.transport = unix for UDS already. QUIC still needs clarification.

@antonfirsov antonfirsov changed the title Figure out how to map UDS and QUIC to network.* attributes Figure out how to map QUIC to network.* attributes Jul 11, 2024
@lmolkova
Copy link
Contributor

lmolkova commented Jul 11, 2024

I don't see any controversy in network.transport=quic ("QUIC (/kwɪk/) is a general-purpose[1] transport layer[2] network protocol")

Do you feel we need to mention it explicitly?

@antonfirsov
Copy link
Author

So there are two different protocols in the same OSI layer while network.transport needs us to pick only one without defining a criteria. #1239 will make things clearer IMO!

@JamesNK
Copy link

JamesNK commented Jul 12, 2024

QUIC is built on top of UDP. Is that a conflict?

@lmolkova
Copy link
Contributor

lmolkova commented Jul 12, 2024

QUIC is built on top of UDP. Is that a conflict?

@JamesNK
it's defined as a transport protocol - using quic would be more precise than using udp. I.e. if we record quic as udp we'd lose some information, but if we record it as quic we won't lose anything. So from my perspective there is no conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants