Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow failed: open-telemetry/opentelemetry.io Build Semantic Conventions (daily) (#6) #1791

Open
opentelemetrybot opened this issue Jan 23, 2025 · 13 comments

Comments

@opentelemetrybot
Copy link

See open-telemetry/opentelemetry.io Build Semantic Conventions (daily) #6.

@trask
Copy link
Member

trask commented Jan 23, 2025

I think the failure is due to the temporary patch put in place due to spec and semconv releases being staggered:

https://github.com/open-telemetry/opentelemetry.io/blob/f45870446397e6d05347ff61cff9d7b6f219f05a/scripts/content-modules/adjust-pages.pl#L138-L142

@chalin can you confirm if there's something for us to do / fix here before we make the semconv release this week?

@chalin
Copy link
Contributor

chalin commented Jan 23, 2025

Right, it's because of the patch. I have been trying to think of a simple way for the patch code to know that it's using semconv at HEAD, and not apply the patch. Haven't found something I'm satisfied with yet.

@opentelemetrybot
Copy link
Author

@chalin
Copy link
Contributor

chalin commented Jan 23, 2025

I've fixed the patch script, see:

@opentelemetrybot
Copy link
Author

@chalin
Copy link
Contributor

chalin commented Jan 23, 2025

Much better now that patches aren't being unnecessarily applied.

From the logs I see that most invalid links are fixes required in OTel.io pages, except for this one:

  hash does not exist --- docs/specs/semconv/exceptions/exceptions-logs/index.html --> /docs/specs/semconv/exceptions/exceptions-spans/#stacktrace-representation

@trask - can I let you dig into that?

@trask
Copy link
Member

trask commented Jan 23, 2025

@trask - can I let you dig into that?

yes, definitely

@trask
Copy link
Member

trask commented Jan 23, 2025

hash does not exist --- docs/specs/semconv/exceptions/exceptions-logs/index.html --> /docs/specs/semconv/exceptions/exceptions-spans/#stacktrace-representation

@chalin sorry, I think I don't understand something about the website link translations, this link looks correct, and works when I test it via its markdown

@chalin
Copy link
Contributor

chalin commented Jan 23, 2025

Here's the cause:

@opentelemetrybot
Copy link
Author

See open-telemetry/opentelemetry.io Build Semantic Conventions (daily) #9.

@chalin
Copy link
Contributor

chalin commented Jan 23, 2025

@trask - can we get the following merged before the next release?

@chalin
Copy link
Contributor

chalin commented Jan 23, 2025

Semconv spec @ HEAD is now green via:

@opentelemetrybot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Need triage
Development

No branches or pull requests

3 participants