-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trace/http: Add semantic convention for total request and response length #38
Comments
Just caught up on the effect of open-telemetry/opentelemetry-specification#3355 which. The ECS names for the fields I'd like are: By analogy with the renamings introduced in that PR, the new attributes should be
|
These attributes are the number of bytes in the request or response, including headers. The names were chosen by taking the [ECS HTTP fields] and replacing `bytes` with `size`, as for `http.request.content.size`. closes open-telemetry#38 [ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
just adding the same heads up here from #84 (comment) (for anyone else viewing the issue):
|
These attributes are the number of bytes in the request or response, including control data, headers, body, and trailers. The names were chosen by taking the [ECS HTTP fields] and replacing `bytes` with `size`, as for `http.request.content.size`. closes open-telemetry#38 [ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
These attributes are the number of bytes in the request or response, including control data, headers, body, and trailers. The names were chosen by taking the [ECS HTTP fields] and replacing `bytes` with `size`, as for `http.request.content.size`. closes open-telemetry#38 [ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
These attributes are the number of bytes in the request or response, including control data, headers, body, and trailers. The names were chosen by taking the [ECS HTTP fields] and replacing `bytes` with `size`, as for `http.request.content.size`. closes open-telemetry#38 [ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
These attributes are the number of bytes in the request or response, including control data, headers, body, and trailers. The names were chosen by taking the [ECS HTTP fields] and replacing `bytes` with `size`, as for `http.request.content.size`. closes open-telemetry#38 [ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
These attributes are the number of bytes in the request or response, including control data, headers, body, and trailers. The names were chosen by taking the [ECS HTTP fields] and replacing `bytes` with `size`, as for `http.request.content.size`. closes open-telemetry#38 [ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
These attributes are the number of bytes in the request or response, including control data, headers, body, and trailers. The names were chosen by taking the [ECS HTTP fields] and replacing `bytes` with `size`, as for `http.request.content.size`. closes open-telemetry#38 [ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
The current
http.request_content_length
andhttp.response_content_length
are specified to be the length of the body excluding headers. I'd like to add an attribute for the total message size.For names, I think
http.request_length
andhttp.response_length
make the most sense.Rationale:
http.server.request.size
andhttp.server.response.size
are in fact measure of total bytes sentThe text was updated successfully, but these errors were encountered: