-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider merging *.cpu.state
metric attributes
#840
Comments
So to summarize the situation here, we have the following: System MetricsValues for
Process MetricsValues for
Container MetricsValues for
Based on @braydonk's comment we can change the Then the only difference with the My first proposal would be to unify the attribute to What do you @open-telemetry/semconv-system-approvers think about this? |
I like the proposal, it simplifies things. @lmolkova Can we limit the valid values of an attribute when used in a concrete context to a subset of the overall allowed values through the tooling? |
Removing the triage label, as this sounds like a good plan. Unifying them makes sense to me. |
@lmolkova any thoughts on #840 (comment)? |
I am in favor of this.
@ishleenk17 I think this is Linux-specific, so it should go into its own separate metric like we did on open-telemetry/build-tools#323 |
@ChrsMark it's not possible yet but we are discussinga few weeks ago this option, one similar reference would be open-telemetry/weaver#479 to exend enum from some |
Area(s)
area:container
area:system
area:process
Is your change request related to a problem? Please describe.
At the moment we have 3 different metric attributes representing the
cpu.state
:system.cpu.state
process.cpu.state
container.cpu.state
Based on the global flat registry idea it would be nice if we had one single definition for this attribute and then be able to re-use it in the various namespaces.
Describe the solution you'd like
As it is explained at #681 (comment) we could consider merging into one single one called
cpu.state
similar to thedisk.io.direction
andnetwork.io.direction
.Describe alternatives you've considered
Maybe the
embed
concept would be sth to think of here: open-telemetry/build-tools#240Additional context
No response
cc @open-telemetry/semconv-system-approvers @open-telemetry/semconv-container-approvers @open-telemetry/semconv-k8s-approvers
The text was updated successfully, but these errors were encountered: