Mark service.version as stable. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
approved these changes
Jun 13, 2023
lmolkova
approved these changes
Jun 14, 2023
joaopgrassi
approved these changes
Jun 15, 2023
reyang
approved these changes
Jun 15, 2023
arminru
approved these changes
Jun 20, 2023
Oberon00
reviewed
Jun 20, 2023
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
|
FYI, our latest change clarifies that version can technically be any string, as defined by the owner, etc. |
Oberon00
reviewed
Jun 20, 2023
| type: string | ||
| brief: > | ||
| The version string of the service API or implementation. The format is not defined by these conventions. | ||
| examples: ["2.0.0"] |
There was a problem hiding this comment.
Please manually apply the markdown suggestion also to the YAML (NB: re-running the genererator will revert @arminru's suggestion; I advise to suggest preferably in the YAML to avoid accidental reverts)
Oberon00
approved these changes
Jun 20, 2023
arminru
reviewed
Jun 20, 2023
| type: string | ||
| brief: > | ||
| The version string of the service API or implementation. The format is not defined by these conventions. | ||
| examples: ["2.0.0"] |
arminru
reviewed
Jun 20, 2023
AlexanderWert
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening this from the related Specification PR.
cc @jsuereth