Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cicd] add initial cicd attributes to registry #1075

Merged
merged 49 commits into from
Jul 19, 2024

Conversation

adrielp
Copy link
Contributor

@adrielp adrielp commented May 25, 2024

Adds proposed CICD common attributes to the registry.

Fixes #915

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

Adjusts the original deployment environment attribute
to match proposal.
@adrielp adrielp requested review from a team May 25, 2024 16:58
@adrielp adrielp changed the title DRAFT [cicd] add initial cicd attributes to registry [cicd] add initial cicd attributes to registry May 25, 2024
@adrielp
Copy link
Contributor Author

adrielp commented May 25, 2024

This pull request comes out of #915. Notably, this comment on the issue. I additionally added the attestation attribute.

As of the time of writing this comment, this pull request does not address the filling:

  • vendor extensions
  • enumerated vendors (eg. db conventions)
  • overarching namespace
  • elaborated descriptions of each attribute. Right now referencing the original issue but will re-eval each description as questions arise.

Will be having some convo's this week & iterating as necessary.

Additionally, I noticed deployment.environment was something already defined as experimental. I've migrated this into the deployment.environment.name attribute. One thing I noticed is that deployment had its own file, so I kept the additional deployment attributes in this file.

This begs the question, should I separate out each namespace (ie. scm, pipeline, etc) into it's own file or should I conglomerate them into cicd.yaml?

docs/attributes-registry/deployment.md Outdated Show resolved Hide resolved
model/registry/deprecated/deployment.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/deployment.yaml Outdated Show resolved Hide resolved
docs/attributes-registry/scm.md Outdated Show resolved Hide resolved
docs/attributes-registry/build.md Outdated Show resolved Hide resolved
docs/attributes-registry/pipeline.md Outdated Show resolved Hide resolved
docs/attributes-registry/pipeline.md Outdated Show resolved Hide resolved
docs/attributes-registry/pipeline.md Outdated Show resolved Hide resolved
model/registry/cicd.yaml Outdated Show resolved Hide resolved
model/registry/cicd.yaml Outdated Show resolved Hide resolved
model/registry/cicd.yaml Outdated Show resolved Hide resolved
schema-next.yaml Outdated Show resolved Hide resolved
docs/resource/deployment-environment.md Outdated Show resolved Hide resolved
model/registry/incident.yaml Outdated Show resolved Hide resolved
model/registry/pipeline.yaml Outdated Show resolved Hide resolved
model/registry/scm.yaml Outdated Show resolved Hide resolved
model/registry/scm.yaml Outdated Show resolved Hide resolved
model/registry/pipeline.yaml Outdated Show resolved Hide resolved
model/registry/incident.yaml Outdated Show resolved Hide resolved
model/registry/test.yaml Outdated Show resolved Hide resolved
model/registry/scm.yaml Outdated Show resolved Hide resolved
model/registry/pipeline.yaml Outdated Show resolved Hide resolved
docs/attributes-registry/test.md Outdated Show resolved Hide resolved
model/registry/test.yaml Outdated Show resolved Hide resolved
model/registry/test.yaml Outdated Show resolved Hide resolved
@adrielp adrielp requested a review from trisch-me July 16, 2024 22:31
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes from our discussion! Looks good.

model/registry/vcs.yaml Outdated Show resolved Hide resolved
model/registry/vcs.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@trisch-me trisch-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this huge PR and work, you have put into it.
I just left minor comments, but they are not affecting my approval

@joaopgrassi joaopgrassi merged commit 5b640ca into open-telemetry:main Jul 19, 2024
12 checks passed
@adrielp adrielp deleted the cicd-reg-attr branch July 19, 2024 15:19
maryliag pushed a commit to maryliag/semantic-conventions that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Proposed Attribute Conventions for CI/CD