Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: update order of db systems on readme #1077

Merged
merged 2 commits into from
May 28, 2024

Conversation

maryliag
Copy link
Contributor

Changes

Small change to alphabetical order of db system, to improve readability.

Merge requirement checklist

Change to alphabetical order of db system, to improve readability.
@maryliag maryliag requested review from a team May 27, 2024 14:15
@joaopgrassi
Copy link
Member

@maryliag did you do these changes manually? AFAIK the order in the yaml shouldn't matter, but the tooling when generating the markdown should order alphabetically already.

Do you happen to know? CC @jsuereth @lquerel as the weaver experts

@maryliag
Copy link
Contributor Author

maryliag commented May 28, 2024

The order in the yaml file is kept in the final readme. So changing the yaml file and regenerating with make table-generation attribute-registry-generation was responsible for updating the tables on the files.

The file docs/attributes-registry/db.md was the only one that got the examples updated with the command, but not the table itself, so that one I did manually.

the tooling when generating the markdown should order alphabetically already.

that is not what is happening, it's just keeping the order of the yaml

@lmolkova lmolkova merged commit 488128d into open-telemetry:main May 28, 2024
12 checks passed
@maryliag maryliag deleted the db-group branch May 28, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants