-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add system.linux.memory.slab to system metrics #1078
add system.linux.memory.slab to system metrics #1078
Conversation
For the attributes, it references the Should this metric reference the |
Thank's @rogercoll for this PR!
I think it makes sense to have a specific
/cc @open-telemetry/semconv-system-approvers @braydonk |
Agreed with @ChrsMark! |
Sounds good to me. To be aligned with the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From SemConv perspective looks good to me.
One question: do we actually plan to implement the system.linux.memory.slab.limit
as well in the Collector?
I would say so, the current sum of all cc @dmitryax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion on attribute naming, look good otherwise!
@rogercoll there are still some failing checks that prevent from merging |
@joaopgrassi could you check this one as you have requested changes but I think it's resolved now |
I think the failing checks are unrelated to the PR but to endpoints blocking the CI IP. Error message:
I can reach the failed endpoint on my end. |
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com> Co-authored-by: Alexandra Konrad <alexandra.konrad@elastic.co> Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Fixes #531
Related to open-telemetry/opentelemetry-collector-contrib#7417
Changes
Adds the
slab
memory metric that is only available on Linux systems assystem.linux.memory.slab
.Merge requirement checklist
[chore]