Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how per-message attributes should be recorded for batch operations and minor cleanups #1168

Merged
merged 10 commits into from
Jun 20, 2024
Merged

Clarify how per-message attributes should be recorded for batch operations and minor cleanups #1168

merged 10 commits into from
Jun 20, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Jun 19, 2024 •
edited
Loading

  • Clarifies per-message attributes section
  • Adds azure messaging to the list of extensions in the cross-signal README and removes list of extensions from spans
  • Removes section that lists messaging.{system}.* namespaces - seems redundant
  • Removes unused yaml

@lmolkova lmolkova requested review from a team June 19, 2024 20:17
@lmolkova lmolkova changed the title [chore] Minor messaging cleanups Clarify how per-message attributes should be recorded for messaging operations Jun 19, 2024
@lmolkova lmolkova changed the title Clarify how per-message attributes should be recorded for messaging operations Clarify how per-message attributes should be recorded for messaging operations and minor cleanups Jun 19, 2024
@lmolkova lmolkova changed the title Clarify how per-message attributes should be recorded for messaging operations and minor cleanups Clarify how per-message attributes should be recorded for batch operations and minor cleanups Jun 19, 2024
joaopgrassi
joaopgrassi approved these changes Jun 20, 2024
View reviewed changes
docs/messaging/messaging-spans.md Outdated Show resolved Hide resolved
joaopgrassi and others added 2 commits June 20, 2024 17:02
@joaopgrassi
Merge branch 'main' into messaging-minor-cleanups
dbd779b
@pyohannes @joaopgrassi
Update docs/messaging/messaging-spans.md
a0fe80b 
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
@joaopgrassi joaopgrassi merged commit 5d8fa26 into open-telemetry:main Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@pyohannes pyohannes pyohannes approved these changes

Assignees

@reyang reyang

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lmolkova @trask @joaopgrassi @pyohannes @reyang