-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenAI: Rename prompt and completion tokens attributes to input and output #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @open-telemetry/semconv-llm-approvers |
nirga
approved these changes
Jul 2, 2024
cartermp
approved these changes
Jul 2, 2024
drewby
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I just had one suggestion around making the descriptions consistent.
jsuereth
approved these changes
Jul 4, 2024
trisch-me
approved these changes
Jul 4, 2024
arminru
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're moved away from prompt/completion terminology on GenAI metrics to accommodate non-chat operations (like embeddings) - see #955 (comment) for the context.
But we didn't rename corresponding attributes on spans.
Changes
Rename:
gen_ai.usage.completion_tokens
togen_ai.usage.output_tokens
gen_ai.usage.prompt_tokens
togen_ai.usage.input_tokens
Merge requirement checklist
[chore]