Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify pool name being unique #1289

Merged
merged 7 commits into from
Aug 1, 2024

Conversation

maryliag
Copy link
Contributor

Changes

Working on the prototype for DB Metrics, the recommendation for using just host:port as a fallback for pool name was not enough to identify a pool, so this PR adds example of how to make the name more unique.

Merge requirement checklist

@maryliag maryliag requested review from a team July 26, 2024 17:06
@maryliag
Copy link
Contributor Author

cc @open-telemetry/semconv-db-approvers

model/registry/db.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova enabled auto-merge (squash) August 1, 2024 15:52
@lmolkova lmolkova merged commit ea6e22b into open-telemetry:main Aug 1, 2024
11 of 13 checks passed
@maryliag maryliag deleted the db-pool-name-attribute branch August 1, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants