-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check attribute/metric/event name format #1302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Aug 1, 2024
jsuereth
approved these changes
Aug 5, 2024
MadVikingGod
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a check for the group.id
?
Other then that looks good.
lmolkova
force-pushed
the
more-naming-policies
branch
from
August 8, 2024 16:13
8813bb9
to
625d3bc
Compare
great point! No check yet, I added it to open-telemetry/weaver#306 - this PR focuses on attributes |
lmolkova
commented
Aug 11, 2024
lmolkova
commented
Aug 15, 2024
lmolkova
force-pushed
the
more-naming-policies
branch
from
August 18, 2024 18:36
625d3bc
to
8110e88
Compare
lmolkova
changed the title
check attribute name format and uniqueness
Check attribute/metric/event name format
Aug 18, 2024
jsuereth
reviewed
Aug 19, 2024
jsuereth
reviewed
Aug 19, 2024
lquerel
reviewed
Aug 19, 2024
@lmolkova I'm merged, and now there's conflicts here... apoligies. |
lmolkova
force-pushed
the
more-naming-policies
branch
from
August 20, 2024 22:48
a0c5dea
to
ebd49c2
Compare
joaopgrassi
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1124
Changes
Merge requirement checklist
[chore]