Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check attribute/metric/event name format #1302

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Aug 1, 2024

Fixes #1124

Changes

  • adds checks for attribute, metrics, and event name format
  • adds a note to the attribute naming about current tooling limitations

Merge requirement checklist

@lmolkova lmolkova requested review from a team August 1, 2024 02:24
Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a check for the group.id?

Other then that looks good.

@lmolkova lmolkova force-pushed the more-naming-policies branch from 8813bb9 to 625d3bc Compare August 8, 2024 16:13
@lmolkova
Copy link
Contributor Author

lmolkova commented Aug 8, 2024

Is there a check for the group.id?

great point! No check yet, I added it to open-telemetry/weaver#306 - this PR focuses on attributes

@lmolkova lmolkova force-pushed the more-naming-policies branch from 625d3bc to 8110e88 Compare August 18, 2024 18:36
@lmolkova lmolkova changed the title check attribute name format and uniqueness Check attribute/metric/event name format Aug 18, 2024
Makefile Outdated Show resolved Hide resolved
policies/yaml_schema.rego Outdated Show resolved Hide resolved
@jsuereth
Copy link
Contributor

@lmolkova I'm merged, and now there's conflicts here... apoligies.

@lmolkova lmolkova force-pushed the more-naming-policies branch from a0c5dea to ebd49c2 Compare August 20, 2024 22:48
@lmolkova lmolkova merged commit 94b186c into open-telemetry:main Aug 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Attribute names: unicode on OTLP, only [a-z0-9._] in OTel semcov
5 participants