-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge experimental and stable attributes per resource type. #1423
Merged
lmolkova
merged 10 commits into
open-telemetry:main
from
jsuereth:wip-join-resource-experimental
Nov 6, 2024
Merged
Merge experimental and stable attributes per resource type. #1423
lmolkova
merged 10 commits into
open-telemetry:main
from
jsuereth:wip-join-resource-experimental
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
joaopgrassi
previously approved these changes
Oct 14, 2024
lmolkova
reviewed
Oct 16, 2024
lmolkova
previously approved these changes
Oct 25, 2024
… resource NOT the same as SDK.
jsuereth
dismissed
lmolkova’s stale review
November 5, 2024 14:50
PR has changed - creating new telemtery.distro resource now
lmolkova
reviewed
Nov 5, 2024
lmolkova
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
joaopgrassi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the experimental and stable portions of
resource
together where previously we had them split by group but still had them with the sametype
.Explicitly calls out resource "types" that have mixed-attribute status.
Note: we can re-enable the appropriate resource compatibility checks AFTER this PR has been released in a new version.
Changes
service
experimental + stable attributes in the same group.telemetry.distro
attributes with thetelmetery.distro.*
attributes.service
resource.Merge requirement checklist
[chore]