Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge experimental and stable attributes per resource type. #1423

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Sep 20, 2024

Merge the experimental and stable portions of resource together where previously we had them split by group but still had them with the same type.

Explicitly calls out resource "types" that have mixed-attribute status.

Note: we can re-enable the appropriate resource compatibility checks AFTER this PR has been released in a new version.

Changes

  • Merge service experimental + stable attributes in the same group.
  • Create telemetry.distro attributes with the telmetery.distro.* attributes.
  • Modify markdown so that both stable + experimental attributes show up joined for a given resource type. This should be temporary just for service resource.

Merge requirement checklist

@jsuereth jsuereth marked this pull request as ready for review October 11, 2024 12:23
@jsuereth jsuereth requested review from a team as code owners October 11, 2024 12:23
joaopgrassi
joaopgrassi previously approved these changes Oct 14, 2024
lmolkova
lmolkova previously approved these changes Oct 25, 2024
@jsuereth jsuereth dismissed lmolkova’s stale review November 5, 2024 14:50

PR has changed - creating new telemtery.distro resource now

docs/resource/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Nov 6, 2024
@lmolkova lmolkova merged commit 2ce39aa into open-telemetry:main Nov 6, 2024
14 of 15 checks passed
@jsuereth jsuereth deleted the wip-join-resource-experimental branch November 6, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants