Re-introduce namespace to describe the original destination #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
force-pushed
the
feat/destination_publish_return
branch
3 times, most recently
from
0f0fea7
to
739974c
Compare
dpauls
approved these changes
Jul 13, 2023
joaopgrassi
force-pushed
the
feat/destination_publish_return
branch
from
739974c
to
6ce2a16
Compare
pyohannes
reviewed
Jul 19, 2023
pyohannes
approved these changes
Jul 28, 2023
|
Hi @open-telemetry/specs-semconv-maintainers this is ready to merge. We have an agreement between the messaging SIG. |
arminru
approved these changes
Aug 7, 2023
bryce-b
pushed a commit
to bryce-b/semantic-conventions
that referenced
this pull request
Aug 8, 2023
…emetry#156) Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
rapphil
pushed a commit
to rapphil/semantic-conventions
that referenced
this pull request
Aug 14, 2023
…emetry#156) Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
This was referenced Sep 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #100, closes #123
As discussed and agreed in the messaging SIG meeting on 2022/06/29 (meeting notes) we are re-introducing the
nameandanonymousattributes under themessaging.destination_publishnamespace.cc @pyohannes @dpauls @lmolkova
PS: I re-added some text from the old PR and re-worked it a bit. Let me know if you think it makes sense!