Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Add missing README.md for Resource Cloud Provider semconv #171

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 7, 2023

Publishing the docs to the OTel website requires that all sections have a README.md file. This adds a README.md that is missing from https://github.com/open-telemetry/semantic-conventions/tree/main/docs/resource/cloud_provider.

@jsuereth @joaopgrassi

/cc @svrnm @cartermp

Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to accept or not my suggestion. If not, I can follow up with it later.

docs/resource/cloud_provider/README.md Show resolved Hide resolved
@chalin chalin force-pushed the chalin-im-rsc-cloud-provider-2023-07-06 branch from 579a06d to 53ee72c Compare July 7, 2023 13:14
@arminru arminru merged commit f36ec6d into open-telemetry:main Jul 7, 2023
8 checks passed
@chalin chalin deleted the chalin-im-rsc-cloud-provider-2023-07-06 branch July 7, 2023 14:44
rapphil pushed a commit to rapphil/semantic-conventions that referenced this pull request Aug 14, 2023
…nv (open-telemetry#171)

Co-authored-by: Joao Grassi <joao@joaograssi.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants