telemetry.distro.name and telemetry.distro.version

[zeitlinger]

• rename telemetry.auto.name resource attribute telemetry.distro.name
• add telemetry.distro.version resource attribute

[jsuereth]

Approved, assuming this is already used / prototyped by the Java instrumentation distributions.

[zeitlinger]

No, it's not prototyped yet. We wanted to have feedback from the spec first - I'll do a prototype now 😄

[Kielek]

Do you have any recommendation how to call official distributions?

There is a strict recommendation what to set for sdk.name attribution

**[1]:** The OpenTelemetry SDK MUST set the `telemetry.sdk.name` attribute to `opentelemetry`.
If another SDK, like a fork or a vendor-provided implementation, is used, this SDK MUST set the
`telemetry.sdk.name` attribute to the fully-qualified class or module name of this SDK's main entry point
or another suitable identifier depending on the language.

[breedx-splk]

I would be in favor of telemetry.distro.name (and version) instead of auto because we also have the need in Android, where it's mostly not "auto-instrumentation". We can use this regardless, it's just less fitting with auto in the name. I think distro is more flexible and applies cleanly to other situations.

[pellared]

I would be in favor of telemetry.distro.name (and version) instead of auto because we also have the need in Android, where it's mostly not "auto-instrumentation". We can use this regardless, it's just less fitting with auto in the name. I think distro is more flexible and applies cleanly to other situations.

Then probably we should also rename telemetry.auto.version to telemetry.distro.version. While I think it is a good idea as the name can even include "auto" to make it clear that the distribution is an automatic instrumentation I would rather prefer to have it as a separate PR.

[AlexanderWert]

I like that proposal.

With a strong +1 on #178 (comment).
So, let's add a similar note for telemetry.auto.name.

[AlexanderWert]

@zeitlinger How do we want to proceed with that?

Do you mind updating the PR to the proposal from above? (updating to telemetry.distro.name + telemetry.distro.version): #178 (comment)

[zeitlinger]

@zeitlinger How do we want to proceed with that?

Do you mind updating the PR to the proposal from above? (updating to telemetry.distro.name + telemetry.distro.version): #178 (comment)

yes, that's a good idea - done 😄

[trask]

re-approving (new name distro)

@zeitlinger can you update the PR title and description to reflect this change?

[pyohannes]

Looks good. @zeitlinger Please add a new schema file with a schema transformation for this change (like here).

[Kielek]

Do you have any recommendation how to call official distributions?

There is a strict recommendation what to set for sdk.name attribution

**[1]:** The OpenTelemetry SDK MUST set the `telemetry.sdk.name` attribute to `opentelemetry`.
If another SDK, like a fork or a vendor-provided implementation, is used, this SDK MUST set the
`telemetry.sdk.name` attribute to the fully-qualified class or module name of this SDK's main entry point
or another suitable identifier depending on the language.

I would like to rise this topic once more time before merging.

[jsuereth]

@zeitlinger This still needs a telemetry schema file

[pyohannes]

@open-telemetry/specs-semconv-maintainers I guess this can be merged?

[joaopgrassi]

The schema changes should be reflected in https://github.com/open-telemetry/semantic-conventions/blob/main/schema-next.yaml and not in a new file IIRC.

Also, was the comment from @Kielek addressed?

Do you have any recommendation how to call official distributions?
There is a strict recommendation what to set for sdk.name attribution

**[1]:** The OpenTelemetry SDK MUST set the `telemetry.sdk.name` attribute to `opentelemetry`.
If another SDK, like a fork or a vendor-provided implementation, is used, this SDK MUST set the
`telemetry.sdk.name` attribute to the fully-qualified class or module name of this SDK's main entry point
or another suitable identifier depending on the language.

I would like to rise this topic once more time before merging.

[zeitlinger]

@joaopgrassi @Kielek thanks for the feedback 😄

Added a section on naming the official distro & fixed the schema file.

[joaopgrassi]

Giving the broad number of approvals and the latest change (even if minor) I think others need to look at it again.