Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[editorial] Link directly to page, not to page's title #180

Merged
merged 3 commits into from
Jul 7, 2023
Merged

[editorial] Link directly to page, not to page's title #180

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e715d3
[editorial] Link directly to page, not to page's title
chalin Jul 7, 2023
2cfbbd0
Merge branch 'main' into chalin-im-link-to-page-not-title-2023-07-07
reyang Jul 7, 2023
0eea0ff
Merge branch 'main' into chalin-im-link-to-page-not-title-2023-07-07
reyang Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/faas/faas-spans.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ See also the [additional instructions for instrumenting AWS Lambda](aws-lambda.m

Span `name` should be set to the function name being executed. Depending on the value of the `faas.trigger` attribute, additional attributes MUST be set. For example, an `http` trigger SHOULD follow the [HTTP Server semantic conventions](/docs/http/http-spans.md#http-server-semantic-conventions). For more information, refer to the [Function Trigger Type](#function-trigger-type) section.

If Spans following this convention are produced, a Resource of type `faas` MUST exist following the [Resource semantic convention](../resource/faas.md#function-as-a-service).
If Spans following this convention are produced, a Resource of type `faas` MUST exist following the [Resource semantic convention](../resource/faas.md).

<!-- semconv faas_span -->
| Attribute | Type | Description | Examples | Requirement Level |
Expand Down Expand Up @@ -87,7 +87,7 @@ The following well-known definitions MUST be used if you set this attribute and
### Function Name

There are 2 locations where the function's name can be recorded: the span name and the
[`faas.name` Resource attribute](../resource/faas.md#function-as-a-service).
[`faas.name` Resource attribute](../resource/faas.md).

It is guaranteed that if `faas.name` attribute is present it will contain the
function name, since it is defined in the semantic convention strictly for that
Expand Down