-
Notifications
You must be signed in to change notification settings - Fork 283
Expand the intended use of the cloud.region attribute #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joaopgrassi
merged 3 commits into
open-telemetry:main
from
SrdjanLL:cloud-region-attr-modification
May 13, 2025
Merged
Expand the intended use of the cloud.region attribute #2238
joaopgrassi
merged 3 commits into
open-telemetry:main
from
SrdjanLL:cloud-region-attr-modification
May 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
May 7, 2025
xrmx
approved these changes
May 7, 2025
Contributor
xrmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small nit but LGTM
8 tasks
…docs to include it as a span attribute.
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
54d0890 to
ef5879d
Compare
lmolkova
approved these changes
May 8, 2025
joaopgrassi
approved these changes
May 13, 2025
lmolkova
pushed a commit
to lmolkova/semantic-conventions
that referenced
this pull request
May 13, 2025
…#2238) Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2142
Changes
cloud.regionattribute to clarify its application. The change ensures it covers use cases not only tied to describing resource location but also captures the region of the destination (dependency) being called.cloud.regionas a span attribute recommendation (as mentioned here).Merge requirement checklist
[chore]