Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all JVM metrics from process.runtime.jvm.* to jvm.* #241

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Rename all JVM metrics from process.runtime.jvm.* to jvm.* #241

merged 4 commits into from
Aug 10, 2023

Conversation

trask
Copy link
Member

@trask trask commented Aug 9, 2023 •
edited
Loading

Fixes #227

I can split these metrics out from runtime-environment-metrics.md into jvm-metrics.md either in this PR or in a follow-up PR.

Changes

Renames all JVM metrics from process.runtime.jvm.* to jvm.*.

Merge requirement checklist

@trask trask marked this pull request as ready for review August 9, 2023 22:00
@trask trask requested review from a team August 9, 2023 22:00
AlexanderWert
AlexanderWert approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@AlexanderWert AlexanderWert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

+1 on moving the metrics into jvm-metrics.md

joaopgrassi
joaopgrassi reviewed Aug 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
docs/system/runtime-environment-metrics.md Outdated Show resolved Hide resolved
docs/system/runtime-environment-metrics.md Show resolved Hide resolved
mateuszrzeszutek
mateuszrzeszutek approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 👍

@joaopgrassi joaopgrassi mentioned this pull request Aug 10, 2023
Merged
jack-berg
jack-berg approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

trask and others added 2 commits August 10, 2023 12:03
@reyang reyang merged commit d5b8de4 into open-telemetry:main Aug 10, 2023
8 checks passed
@trask trask deleted the rename-jvm-metrics branch August 11, 2023 16:14
rapphil pushed a commit to rapphil/semantic-conventions that referenced this pull request Aug 14, 2023
@trask @rapphil
Rename all JVM metrics from process.runtime.jvm.* to jvm.* (open-tele…
a6c3202 
…metry#241)
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Aug 16, 2023
@trask @ChrsMark
Rename all JVM metrics from process.runtime.jvm.* to jvm.* (open-tele…
99fcf82 
…metry#241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopgrassi joaopgrassi joaopgrassi left review comments

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jack-berg jack-berg jack-berg approved these changes

@reyang reyang reyang approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

Assignees

@jsuereth jsuereth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename process.runtime.jvm.* namespace to simply jvm.*
7 participants
@trask @AlexanderWert @joaopgrassi @reyang @jack-berg @mateuszrzeszutek @jsuereth