-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename http body size metrics to match attribute names #247
Merged
arminru
merged 5 commits into
open-telemetry:main
from
trask:rename-http-body-size-metrics
Sep 21, 2023
Merged
Rename http body size metrics to match attribute names #247
arminru
merged 5 commits into
open-telemetry:main
from
trask:rename-http-body-size-metrics
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
rename-http-body-size-metrics
branch
from
August 13, 2023 21:18
2901149
to
6a1740b
Compare
trask
force-pushed
the
rename-http-body-size-metrics
branch
from
August 13, 2023 21:20
6a1740b
to
f48794d
Compare
jsuereth
approved these changes
Aug 14, 2023
mateuszrzeszutek
approved these changes
Aug 14, 2023
reyang
approved these changes
Aug 14, 2023
@trask need to resolve merge conflicts. |
joaopgrassi
approved these changes
Aug 21, 2023
trask
force-pushed
the
rename-http-body-size-metrics
branch
from
September 20, 2023 22:40
44d706a
to
d0eed3f
Compare
trask
force-pushed
the
rename-http-body-size-metrics
branch
from
September 20, 2023 22:47
d0eed3f
to
26c0e51
Compare
trask
force-pushed
the
rename-http-body-size-metrics
branch
from
September 20, 2023 22:51
41a20c5
to
311b219
Compare
pyohannes
approved these changes
Sep 21, 2023
arminru
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Changes
Renames
http.server.request.size
metric tohttp.server.request.body.size
andhttp.server.response.size
metric tohttp.server.response.body.size
.Merge requirement checklist