Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port, address clarifications #289

Merged
merged 17 commits into from
Sep 29, 2023
Merged

Port, address clarifications #289

merged 17 commits into from
Sep 29, 2023

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Aug 29, 2023 •
edited
Loading

Fixes #250

Changes

  • Encourage setting network.transport when reporting port numbers
  • (No changelog:) Re-arrange section structure of networking-related attributes (keep them in general attributes.md for now)

Merge requirement checklist

@Oberon00 Oberon00 requested review from a team August 29, 2023 10:45
@Oberon00 Oberon00 mentioned this pull request Aug 29, 2023
Closed
joaopgrassi
joaopgrassi reviewed Aug 30, 2023
View reviewed changes
docs/general/attributes.md Outdated Show resolved Hide resolved
docs/general/attributes.md Outdated Show resolved Hide resolved
docs/general/attributes.md Outdated Show resolved Hide resolved
@Oberon00 @joaopgrassi
Apply suggestions from code review
ad95e6a 
Co-authored-by: Joao Grassi <joao@joaograssi.com>
trask
trask approved these changes Aug 31, 2023
View reviewed changes
docs/database/database-spans.md Outdated Show resolved Hide resolved
Oberon00
Oberon00 commented Aug 31, 2023
View reviewed changes
model/network.yaml Outdated Show resolved Hide resolved
@Oberon00 Oberon00 requested a review from a team September 26, 2023 15:29
@Oberon00
Copy link
Member Author

Is there any blocker for merging this? I resolved the old conversations, IMHO this is ready.

@trask
Copy link
Member

trask commented Sep 28, 2023

Is there any blocker for merging this? I resolved the old conversations, IMHO this is ready.

@open-telemetry/specs-semconv-maintainers bump

This was referenced Sep 29, 2023
Closed
Merged
@reyang reyang merged commit 50c5424 into open-telemetry:main Sep 29, 2023
8 checks passed
breedx-splk pushed a commit to breedx-splk/semantic-conventions that referenced this pull request Oct 3, 2023
@Oberon00 @breedx-splk
Port, address clarifications (open-telemetry#289)
d20f061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek left review comments

@lmolkova lmolkova lmolkova approved these changes

@trask trask trask approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@reyang reyang

Labels
None yet
Projects
Spec: HTTP Semantic Conventions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disconnect between server/client(.socket).port and network.transport (TCP/UDP)
7 participants
@Oberon00 @trask @jsuereth @lmolkova @joaopgrassi @mateuszrzeszutek @reyang